New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MTB_MTS_XDOT as a new target #5975

Merged
merged 3 commits into from Feb 6, 2018

Conversation

Projects
None yet
7 participants
@ashok-rao
Contributor

ashok-rao commented Jan 30, 2018

Description

Adding MTS xDOT (MTB) as a new target.

Status

READY

Todos

  • Tests
  • Documentation

@0xc0170 , attaching GT logs below. GCC and ARMCC are Passing while IAR is failing due to low RAM (32K) on this target. Tagging @geky for pointers on this.

MTB_xDOT_GT_Log_ARMCC_Pass.txt
MTB_xDOT_GT_Log_GCC_Pass.txt
MTB_xDOT_GT_Log_IAR_Fail.txt

cc @screamerbg @chris-styles @studavekar

@geky

This comment has been minimized.

Member

geky commented Jan 30, 2018

@theotherjimmy, @studavekar, thoughts on providing the cmsis ROM/RAM info as defines so tests could filter based on available ROM/RAM? It looks like this would be needed for devices with <64KB RAM for the filesystem tests due to the reliance on the heap block device.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jan 30, 2018

@geky I would like to discuss that in an issue :D. For now, I think turning just this target off for that one test is a welcome workaround.

@0xc0170 0xc0170 added the needs: work label Jan 31, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 31, 2018

As it's just IAR, this is again related to non dynamic heap - would IAR 8 update fix this?

It looks like this would be needed for devices with <64KB RAM for the filesystem tests due to the reliance on the heap block device.

Those 2 tests that are failing for this device, do they need more than 32kB RAM devices? I think assuming 32kB limit should be fine.

Having a discussion about ROM/RAM would be good. There is still opened PR about minimum memory requirements test that is waiting for IAR 8 to get in.

Back to this target addition, @geky - can we make those 2 tests run without decreasing the functionality on a target with 32kB?

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Jan 31, 2018

@0xc0170 ..looks like travis is failing for a different (& new target)..not related to this target..

For now, I think turning just this target off for that one test is a welcome workaround.

@geky ..Can this be done for this target only to get through CI?

@geky

This comment has been minimized.

Member

geky commented Jan 31, 2018

@theotherjimmy, are you thinking ifdefs in the test based on the TARGET_MTB_MTS_XDOT?

Technically we can, but it seems like a point solution. @0xc0170, are you ok with this?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jan 31, 2018

@geky Yeah, I was thinking that might be an okay workaround for now.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 1, 2018

Technically we can, but it seems like a point solution. @0xc0170, are you ok with this?

Yes, fine but not as long term fix. Still would like to understand the test requirements and if this device can fulfill those

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Feb 1, 2018

Thanks @0xc0170.
@geky , we need to get this merged for 5.7.5. Can you please help? Thank you.

Workaround for insufficient heap on IAR+MTB_xDOT_GT
We currently don't have a mechanism for selecting tests based on the
available ram/heap, so the best solution right now is to disable these
tests specifically for this target.
@geky

This comment has been minimized.

Member

geky commented Feb 1, 2018

Should be good to go now

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Feb 2, 2018

@0xc0170 ..over to you for review and CI..thanks!

@geky

This comment has been minimized.

Member

geky commented Feb 2, 2018

@cmonr is also managing the queue I believe

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Feb 2, 2018

@cmonr .. could you please review / CI..? Thank you...

@cmonr cmonr self-requested a review Feb 2, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 2, 2018

/morph build

@cmonr

cmonr approved these changes Feb 2, 2018

@cmonr cmonr added needs: CI and removed needs: work labels Feb 2, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 2, 2018

Man, @geky, that hack makes me uncomfortable, but if it's what's needed and this needs to be pushed in quickly, then so be it.

@geky @ashok-rao I would appreciate seeing an issue opened and reference to this PR so that we can track that hack, and revert it when a proper solution is make.

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 2, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 3, 2018

@ashok-rao, hope you don't mind, but I added a second LED definition that was apparently needed for tests, since it would be nice if we had CI results by the start of next week.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 3, 2018

Build : SUCCESS

Build number : 1055
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5975/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 3, 2018

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Feb 4, 2018

@cmonr ..sure, thanks for adding the LED define.. Looks like the tests are all green now. Thanks.

Issue #6008 is now raised for this for further discussions..

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Feb 6, 2018

@0xc0170 ..will this go into 5.7.5 release?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 6, 2018

Yes, will be

@cmonr cmonr merged commit 8ae8089 into ARMmbed:master Feb 6, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment