New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LAIRD_BL600 MTB #5996

Merged
merged 2 commits into from Feb 8, 2018

Conversation

Projects
None yet
5 participants
@ashok-rao
Contributor

ashok-rao commented Feb 1, 2018

Description

Adding Laird BL600 as a new target.

Status

READY

Todos

  • Tests
  • Documentation

@0xc0170 .. attaching GT logs below. Please note from the logs that only 1 test case "Test timers: 2x callbacks" in the suite "mbed-os-tests-mbed_drivers-ticker" is failing in both GCC and IAR while rest all tests are passing. ARMCC however passes everything. Any thoughts on this will be helpful. Thank you.

MTB_BL600_GT_ARMCC_Pass.txt
MTB_BL600_GT_GCC_Fail.txt
MTB_BL600_GT_IAR_Fail.txt

cc @screamerbg @chris-styles @studavekar

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 1, 2018

I'm curious what others think. To me, lines 153 and 154 in TESTS/mbed_drivers/ticker/main.cpp should be swapped to prevent a potential race condition.

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Feb 2, 2018

@geky @theotherjimmy @0xc0170 ..what do you guys think?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 2, 2018

@cmonr It acts over serial, so that was probably done to reduce the jitter due to serial transmission.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 5, 2018

#5971 might resolve the issue? If not, please comment there

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Feb 6, 2018

@0xc0170 .. thanks for providing the link to PR #5971. Happy to confirm that the ticker tests are now passing with those changes to the /TESTS/mbed_drivers/ticker/main.cpp applied locally. Please find the passing logs attached below:

MTB_BL600_GT_GCC_ticker_PASS.txt
MTB_BL600_GT_IAR_ticker_PASS.txt

I think this PR can now be taken forward for review / CI. Thanks!

@0xc0170 0xc0170 referenced this pull request Feb 6, 2018

Merged

Ticker tests fix #5971

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 7, 2018

Build : SUCCESS

Build number : 1082
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5996/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Feb 8, 2018

Thank you @cmonr .. @0xc0170 can this go into 5.7.5 as well please?

@0xc0170 0xc0170 merged commit 9f6eb14 into ARMmbed:master Feb 8, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment