New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict target_overrides usage #5998

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Feb 1, 2018

This will prevent a user from doing the invalid:

{
   "target_overrides": {
        "*": {
            "foo": {},
            "foo.foo.foo": true
        }
}
@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 1, 2018

For context, why is the above pattern bad?

Is foo.foo.foo not considered its own thing?

@cmonr cmonr added the needs: review label Feb 1, 2018

@pan- pan- changed the title from Restrict target_overries usage to Restrict target_overrides usage Feb 2, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 2, 2018

@cmonr We only have a 2 level hierarchy: {libname|target|app}.parameter

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 2, 2018

Further, setting a configuration parameter to {} is not allowed. Both lines generate errors (at the same time)

@cmonr

cmonr approved these changes Feb 2, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 2, 2018

Build : SUCCESS

Build number : 1050
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5998/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 3e5fafd into ARMmbed:master Feb 3, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment