New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue "serial example callback not working" #6009

Merged
merged 2 commits into from Feb 14, 2018

Conversation

Projects
None yet
4 participants
@prashantrar
Contributor

prashantrar commented Feb 4, 2018

Description

This PR fixes issue #5805. The changes have been made only in one file.

The "CONFIG_MBED_ENABLED" macro has been put so that the software is compatible with our own internal SDK.

The other changes is to add support for loguart hardware in the normal serial api.

Status

READY/

Migrations

NO

@0xc0170

The commit does not specify how this fixes the issue (please provide a new paragraph with details)

void serial_irq_handler(serial_t *obj, uart_irq_handler handler, uint32_t id)
{
#ifdef CONFIG_MBED_ENABLED

This comment has been minimized.

@0xc0170

0xc0170 Feb 5, 2018

Member

why CONFIG_MBED_ENABLED is here needed?

This comment has been minimized.

@prashantrar

prashantrar Feb 6, 2018

Contributor

I have just updated the description

This comment has been minimized.

@0xc0170

0xc0170 Feb 6, 2018

Member

Thanks

The "CONFIG_MBED_ENABLED" macro has been put so that the software is compatible with our own internal SDK.

I can see it is used in this file. I just do not follow how is it used. If config is enabled then what changes ? Why serial_api.c depends on the config enabled?

This comment has been minimized.

@prashantrar

prashantrar Feb 6, 2018

Contributor

We are reusing the same file in our internal SDK and within realtek, we are trying to maintain one single repository structure for all projects so when we build our SDK, it would refer to this same file. Our loguart is slightly different in nature and hence the changes

@0xc0170 0xc0170 added the needs: work label Feb 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 6, 2018

Can you amend the commit message to provide more details how it is being fixed please? It would be helpful.

@0xc0170

0xc0170 approved these changes Feb 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 7, 2018

As soon as the commit contains info about the fix, we will run CI

Fixing coding style
Fix Details: HAL API for loguart is different that UART. Initially we
didnt have support for loguart in the mbed api. These changes have been
made to support the loguart from the mbed api by using the correct HAL
api calls

@prashantrar prashantrar force-pushed the prashantrar:mbed-os-serial-fix-pr branch from 0724011 to 011dbff Feb 9, 2018

@prashantrar

This comment has been minimized.

Contributor

prashantrar commented Feb 9, 2018

I have updated the commit message just now, please let me know if any extra information is needed.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 9, 2018

I have updated the commit message just now, please let me know if any extra information is needed.

Thanks, but the details were added to the style change not the fix?

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 14, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 14, 2018

We will squash these 2 commits into one

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 14, 2018

Build : SUCCESS

Build number : 1134
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6009/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 14, 2018

@cmonr cmonr merged commit 8ed53a9 into ARMmbed:master Feb 14, 2018

17 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment