New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template update #6078

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
7 participants
@0xc0170
Member

0xc0170 commented Feb 13, 2018

This is the new template proposal below, please review. The idea here is to have 2 sections that needs to be filled in (description and pull request (PR) type).

Note: workflow url should be updated to point to a good PR example (@AnotherButler Can you help to get that url to a specific section? We will create new PR to handbook shortly, will be referenced in this PR).


Description

Detailed changes summary | testing | dependencies
Good example: https://os.mbed.com/docs/latest/reference/guidelines.html#workflow

Pull request type

  • Fix
  • Refactor
  • New Target
  • Feature

@0xc0170 0xc0170 requested review from cmonr, sg-, theotherjimmy and adbridge Feb 13, 2018

@0xc0170 0xc0170 force-pushed the 0xc0170:dev_template_pr branch from b83fde9 to 8af2736 Feb 13, 2018

@adbridge

LGTM

@theotherjimmy

Sure. Maybe more people will fill it out if it's shorter.

@cmonr

cmonr approved these changes Feb 13, 2018

Non-blocking comment/question. LGTM.

## Description
> Detailed changes summary | testing | dependencies
> Good example: https://os.mbed.com/docs/latest/reference/guidelines.html#workflow

This comment has been minimized.

@cmonr

cmonr Feb 13, 2018

Contributor

Is this meant to point to an example bug/issue/PR?

This comment has been minimized.

@0xc0170

0xc0170 Feb 14, 2018

Member

Yes, my comment above:

Note: workflow url should be updated to point to a good PR example (@AnotherButler Can you help to get that url to a specific section? We will create new PR to handbook shortly, will be referenced in this PR).

I'll attach here the PR addition that gives a good example

This comment has been minimized.

@0xc0170

0xc0170 Feb 19, 2018

Member

@AnotherButler the workflow PR template was merged, when it is published so I can edit the line 4 (update url to point to it) ? Or is it fine with link as it is ? This is the last blocking part for this PR

This comment has been minimized.

@0xc0170

0xc0170 Feb 19, 2018

Member

I noticed Pull request template is already in the docs, but I do not see any anchor that I could add here. Is workflow enough (users need to scroll a bit to get the info we would like to)

@0xc0170 0xc0170 referenced this pull request Feb 14, 2018

Merged

PR template addition #411

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 15, 2018

Waiting on ARMmbed/mbed-os-5-docs#411 to be integrated, will update the url here to point to that. please review it (to have a good example how PR description should look like)

@0xc0170 0xc0170 requested a review from AnotherButler Feb 16, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 16, 2018

@AnotherButler Please review

@AnotherButler

Nice work on this 👍

@sg-

sg- approved these changes Feb 19, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 20, 2018

/morph build

Pull request template update
New version of the PR template.

Ideal PR should contain:

- detailed description of changes
- how it was tested
- dependencies
- PR type (one of)

@0xc0170 0xc0170 force-pushed the 0xc0170:dev_template_pr branch from 8af2736 to 775a1fb Feb 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 20, 2018

Ready now, I fixed the link (added there a comment about (Pull request template)).

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 20, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 20, 2018

Build : SUCCESS

Build number : 1185
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6078/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 20, 2018

Build : SUCCESS

Build number : 1186
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6078/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 20, 2018

/morph test

@mbed-ci

This comment has been minimized.

1 similar comment
@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 20, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1198
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6078/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit c32b822 into ARMmbed:master Feb 22, 2018

18 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment