New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: build: fix handing of "--stats-depth" #6083

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
6 participants
@TeroJaasko
Contributor

TeroJaasko commented Feb 13, 2018

Description

The introduction of pretty-bar had broken the handling of
"mbed compile"'s "--stats-depth" argument. No matter what one gave
as parameter to it, the result output is just using the default 2.
Fix the logic in build_api.

Status

READY

Migrations

NO

Related PRs

Todos

  • Tests
  • Documentation

Deploy notes

Steps to test or reproduce

"mbed compile -m K64F -t GCC_ARM --stats-depth 1" and "mbed compile -m K64F -t GCC_ARM --stats-depth 10" both give same output on current Mbed OS master. This PR fixes the parameter handing.

tools: build: fix handing of "--stats-depth"
The introduction of pretty-bar had broken the handling of
"mbed compile"'s "--stats-depth" argument. No matter what one gave
as parameter to it, the result output is just using the default 2.
Fix the logic in build_api.

@0xc0170 0xc0170 requested a review from theotherjimmy Feb 13, 2018

@theotherjimmy

Looks great! Thanks!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 13, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 13, 2018

Build : SUCCESS

Build number : 1127
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6083/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@geky

geky approved these changes Feb 13, 2018

My bad!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 14, 2018

@cmonr cmonr merged commit ea411ef into ARMmbed:master Feb 14, 2018

17 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details
@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 14, 2018

@geky Did you really review your own PR? xD

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 14, 2018

@cmonr He did not make this PR.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 14, 2018

Oh. Hah, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment