New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed-mesh-api: add JSON help #6092

Merged
merged 2 commits into from Mar 15, 2018

Conversation

Projects
None yet
6 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Feb 14, 2018

This pulls in the help that was in the Markdown moved from this repo to the handbook in #5731 and being discussed in ARMmbed/mbed-os-5-docs#366

@kjbracey-arm kjbracey-arm requested review from karsev and AnotherButler Feb 14, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

@karsev and @AnotherButler Can you review the pull request?

@karsev

This comment has been minimized.

Contributor

karsev commented Feb 21, 2018

Could you add the following to the help text ->
PSKd: uppercase alphanumeric characters (0-9,A-Y excluding I,O,Q, and Z) 6 to 32 characters.
Network name: max 16 characters.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

@kjbracey-arm Thoughts on @karsev's comment?

@kjbracey-arm kjbracey-arm dismissed stale reviews from AnotherButler and 0xc0170 via ba30624 Mar 6, 2018

@@ -46,7 +46,7 @@
"value": "NET_6LOWPAN_ROUTER"
},
"thread-pskd": {
"help": "Human-scaled commissioning credentials (string 6-255 chars).",
"help": "Human-scaled commissioning credentials. Uppercase alphanumeric string (0-9, A-Y excluding I, O, Q and Z), 6-32 characters).",

This comment has been minimized.

@cmonr

cmonr Mar 6, 2018

Contributor

Sorry to be that guy, but you have an extra ) at the end of the sentence.
Once it's gone, I'll start CI. Feel free to squash your commits as well.

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Mar 7, 2018

Contributor

Oops. Will keep as 2 commits, as first is just transplanting existing help text from other places, the second is new edits.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:mesh-help branch from ba30624 to 79b3d06 Mar 7, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 12, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 12, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 12, 2018

@AnotherButler Happy with this json help?

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 12, 2018

Build : SUCCESS

Build number : 1419
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6092/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 12, 2018

Test CI canceled due to 5.8.0-RC2 generation. Will resume once 5.8.0-RC2 is released.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 12, 2018

Making a note: Exporter Build failure unrelated to PR. Will restart when able.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 15, 2018

/morph test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2018

@cmonr cmonr merged commit abb74e8 into ARMmbed:master Mar 15, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment