New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate/Link secure object file #6096

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
5 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Feb 14, 2018

Cortex v8 architecture based devices support secure/non-secure builds. Secure build should generate the object file/library from elf during link process which is used by non-secure binary during linking.

--out-implib=file specifies output library in which symbols are exported --cmse-implib requests libraries mentioned above are secure gateway libraries

Creation of secure library is done as part of linking process in GCC/ARMC6/IAR Non-Secure project should add this secure object file as part of the linking process.
Secure library is named as cmse_lib.o.

@deepikabhavnani deepikabhavnani requested a review from theotherjimmy Feb 14, 2018

@theotherjimmy

A few style nits

@@ -15,7 +15,7 @@
limitations under the License.
"""
import re
from os.path import join, basename, splitext, dirname, exists
from os.path import join, basename, splitext, dirname, exists, split

This comment has been minimized.

@theotherjimmy

theotherjimmy Feb 14, 2018

Contributor

I don't think this change is required. Could you remove it?

@@ -16,7 +16,7 @@
"""
import re
from os import remove
from os.path import join, splitext, exists
from os.path import join, splitext, exists, dirname

This comment has been minimized.

@theotherjimmy

theotherjimmy Feb 14, 2018

Contributor

I don't think this is used, could you remove this change?

@@ -66,6 +66,7 @@ def __init__(self, target, notify=None, macros=None,
cxx_flags_cmd = [
"--c++", "--no_rtti", "--no_exceptions"
]

This comment has been minimized.

@theotherjimmy

theotherjimmy Feb 14, 2018

Contributor

Could you remove this style change?

@@ -188,6 +195,7 @@ def link(self, output, objects, libraries, lib_dirs, mem_map):
map_file = splitext(output)[0] + ".map"
cmd = self.ld + [ "-o", output, "--map=%s" % map_file] + objects + libraries

This comment has been minimized.

@theotherjimmy

theotherjimmy Feb 14, 2018

Contributor

Could you remove this style change?

Generate/Link secure object file
Cortex v8 architecture based devices support secure/non-secure builds.
Secure build should generate the object file/library from elf during link
process which is used by non-secure binary during linking.

--out-implib=file specifies output library in which symbols are exported
--cmse-implib requests libraries mentioned above are secure gateway
libraries

Creation of secure library is done as part of linking process in GCC/ARMC6/IAR
Non-Secure project should add this secure object file as part of the
linking process.
Secure library is named as cmse_lib.o.

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:secure_lib_creation branch from a358eee to b21e93b Feb 14, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Feb 14, 2018

@theotherjimmy - Update the code with style fixes

@theotherjimmy

Looks good. Thanks.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Feb 14, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 14, 2018

Build : SUCCESS

Build number : 1142
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6096/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 14, 2018

Re-triggering.
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 15, 2018

@cmonr cmonr merged commit df4ceee into ARMmbed:master Feb 15, 2018

17 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 15, 2018

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:secure_lib_creation branch Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment