New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests-events-timing: print debug info only in case of failure #6135

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
3 participants
@mprse
Member

mprse commented Feb 19, 2018

Description

In the Testing accuracy of equeue semaphore test case result is printed out in each loop iteration. This gives lots of prints during test case execution.
Since debug prints should not exist in the final test version I suggest to print information only in case of failure.
Additionally time needed to print single info is about ~25 ms (K64F/GCC_ARM). The while loop is designed to execute until 20000 ms elapses, so this print has also impact on number of times the loop is executed (number of semaphore accuracy checks).

Status

READY

Migrations

NO

tests-events-timing - print debug info only in case of failure.
In the 'Testing accuracy of equeue semaphore' test case result is printed out in each loop iteration.
Since debug prints should not exist in the final test version I suggest to print information only in case of failure.
Additionally time needed to print single info is equal to ~25 ms (K64F/GCC_ARM). The while loop is designed to execute until 20000 ms elapses, so this print has also impact on number of times the loop is executed (number of semaphore accuracy checks).
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 19, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label Feb 19, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 19, 2018

Build : SUCCESS

Build number : 1168
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6135/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit acd1895 into ARMmbed:master Feb 19, 2018

18 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details

@0xc0170 0xc0170 changed the title from tests-events-timing - print debug info only in case of failure. to tests-events-timing: print debug info only in case of failure Feb 19, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment