New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct single file excludes for some exporters #6145

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
6 participants
@theotherjimmy
Contributor

theotherjimmy commented Feb 20, 2018

Resolves #6060

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 20, 2018

/morph build

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:exclude-file-gnuarmeclipse branch from 941b0a7 to 166a463 Feb 20, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 20, 2018

Build : SUCCESS

Build number : 1190
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6145/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@JojoS62

This comment has been minimized.

Contributor

JojoS62 commented Feb 20, 2018

@theotherjimmy as you're working on the exporters, I'm checking if this is reported already: the gnuarmeclipse creates unnecessary include file entries in the .cproject for a lot of Feature/... directories. For the target -m BLUEPILL_F103C8 for example for lorawan, mbedtls, nanostack and more. Are these features default? In the target.json they are not defined for this target, how is it determined which features to add?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 20, 2018

Are these features default?

Yes.

In the target.json they are not defined for this target, how is it determined which features to add?

They need to be behind FEATURE_ directories to be "disableable".

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 20, 2018

/morph test

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Feb 20, 2018

Test : FAILURE
Build number : 993
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6145/993

Build was tagged with SHA 941b0a7 , however tests are looking for 166a463

@cmonr any idea ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

@studavekar Seems similar to #6078 (comment) ? Where can I obtain sha as you did ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

Seems like first build was before the last commit, rerunning.

@studavekar Shall this be fixed (kill any running job for the PR if we run again) ?

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1202
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6145/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 21, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 22, 2018

@cmonr cmonr merged commit d9cb00d into ARMmbed:master Feb 22, 2018

18 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment