New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 6150 #6160

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
8 participants
@TeemuKultala
Contributor

TeemuKultala commented Feb 22, 2018

Description

This is a fix for issue 6150: #6150. Tested with the cellular unit test

Pull request type

  • Fix
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 22, 2018

@RobMeades Please review

@0xc0170 0xc0170 requested review from kjbracey-arm and mikaleppanen Feb 22, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 22, 2018

@TeemuKultala It would be helpful if you can add more info to the commit message (how is this fixing and what is fixing).

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Feb 22, 2018

@RobMeades Here is the fix for #6150 Please reveiw

@RobMeades

This comment has been minimized.

Contributor

RobMeades commented Feb 22, 2018

Confirmed that this fixes #6150, meaning that the unit tests mbed-os-features-netsocket-cellular-generic_modem_driver-tests-unit_tests-default now pass for me here on a UBLOX_C030_U201 board.

Many thanks for the swift fix.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 22, 2018

@TeemuKultala CI will be run as soon as commit msg is updated as requested

@TeemuKultala TeemuKultala force-pushed the TeemuKultala:status_callback_fix branch from 1ccb883 to 34ef116 Feb 22, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 22, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 22, 2018

Build : SUCCESS

Build number : 1218
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6160/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 1d1eef4 into ARMmbed:master Feb 23, 2018

18 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details

@TeemuKultala TeemuKultala deleted the TeemuKultala:status_callback_fix branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment