New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Laird BL652 as new target #6164

Merged
merged 2 commits into from Mar 8, 2018

Conversation

@ashok-rao
Contributor

ashok-rao commented Feb 22, 2018

Description

Adding Laird BL652 as a new target.

Pull request type

  • New Target

Greentea: all tests passing. Logs attached below.

GT_log_ARMCC_Pass.txt
GT_log_GCC_Pass.txt
GT_log_IAR_Pass.txt

cc @screamerbg @chris-styles @0xc0170

@cmonr cmonr requested review from screamerbg and chris-styles Feb 22, 2018

@cmonr cmonr added the needs: review label Feb 22, 2018

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Mar 1, 2018

@0xc0170 @cmonr .. could you please review (this is similar to other MTB targets that I've added) & let me know your thoughts?

@cmonr cmonr self-requested a review Mar 1, 2018

@cmonr

Comment related questions.

@@ -0,0 +1,23 @@
// The 'features' section in 'target.json' is now used to create the device's hardware preprocessor switches.

This comment has been minimized.

@cmonr

cmonr Mar 6, 2018

Contributor

Is this comment suppose to be here?

This comment has been minimized.

@ashok-rao

ashok-rao Mar 6, 2018

Contributor

I feel so as the features section is used on the MCU level. Not specifically used for any of the modules (so far).. but may be required in the future??

This comment has been minimized.

@cmonr

cmonr Mar 7, 2018

Contributor

Alright, that's fine with me then.
Just seemed odd to see something before the license header.

},
"overrides": {
"lf_clock_src": "NRF_LF_SRC_RC",
"uart_hwfc": 0

This comment has been minimized.

@cmonr

cmonr Mar 6, 2018

Contributor

Minor nit. Mind fixing this indentation?

This comment has been minimized.

@ashok-rao

ashok-rao Mar 6, 2018

Contributor

Fixed. Thanks!

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

@0xc0170 Think you could also give a quick look-over?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

@screamerbg @chris-styles Ping for review.

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Mar 6, 2018

@cmonr @0xc0170 ..review comments incorporated. Could you please re-check ? Thanks.

@cmonr

cmonr approved these changes Mar 7, 2018

@@ -0,0 +1,23 @@
// The 'features' section in 'target.json' is now used to create the device's hardware preprocessor switches.

This comment has been minimized.

@cmonr

cmonr Mar 7, 2018

Contributor

Alright, that's fine with me then.
Just seemed odd to see something before the license header.

@cmonr cmonr requested a review from marcuschangarm Mar 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 7, 2018

@marcuschangarm Wondering if you could take a quick look, particularly with target.json.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 7, 2018

Build : SUCCESS

Build number : 1375
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6164/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

0xc0170 approved these changes Mar 7, 2018

@mbed-ci

This comment has been minimized.

"usb_rx": {
"help": "Value SIO_08",
"value": "SIO_8"
}

This comment has been minimized.

@marcuschangarm

marcuschangarm Mar 7, 2018

Contributor

What are usb_tx and usb_rx being used for?

This comment has been minimized.

This comment has been minimized.

@marcuschangarm

marcuschangarm Mar 8, 2018

Contributor

But none of our code base uses the USB_RX configuration flag. It looks like dead code.

This comment has been minimized.

@ashok-rao

ashok-rao Mar 8, 2018

Contributor

Isn't USB_TX and USB_RX standardised pins to be defined as part of DAPLink pins in the pin defines? along with BUTTON and LED's..?

This comment has been minimized.

@ashok-rao

ashok-rao Mar 9, 2018

Contributor

Ah, I see.. good to know. I'll create a different PR to optimise this target then. Thanks!

This comment has been minimized.

@marcuschangarm

marcuschangarm Mar 9, 2018

Contributor

I wouldn't worry about it to be honest! 😄 We are very close to merging the NRF52 feature branch anyway and we'll be cleaning up all the NRF52 based targets at that point!

},
"overrides": {
"lf_clock_src": "NRF_LF_SRC_RC",
"uart_hwfc": 0

This comment has been minimized.

@marcuschangarm

marcuschangarm Mar 7, 2018

Contributor

What firmware is the board running on the interface chip?

This comment has been minimized.

@ashok-rao

ashok-rao Mar 8, 2018

Contributor

DAPLink ..the MTB is running DAPLink ..the MCB (with the BL652 module) communicates over USB via the MTB..

This comment has been minimized.

@marcuschangarm

marcuschangarm Mar 8, 2018

Contributor

Right, but which one? Do you know if they have flow control enabled like on the Nordic boards?

This comment has been minimized.

@ashok-rao

ashok-rao Mar 8, 2018

Contributor

You mean which DAPLink version (if yes, then there isn't one that's released yet!) We got a custom build from @c1728p9 . Regarding flow control, it's enabled in the parent target by default. I had to disable it for this module. With it enabled (default), I wasn't seeing any printf's coming out of the UART..

This comment has been minimized.

@marcuschangarm

marcuschangarm Mar 9, 2018

Contributor

Ok, good to know! Some Daplinks require flow control to enabled, some doesn't.

@0xc0170 0xc0170 merged commit cf4c7a5 into ARMmbed:master Mar 8, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment