New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct syntax for mbed export in Py3 #6192

Merged
merged 2 commits into from Mar 19, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Feb 23, 2018

No description provided.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 26, 2018

Does this require #6200 to be resolved to have it fully tested?

@0xc0170

The changes might have been split (removing debug messages, fixing syntax errors for python3).

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 28, 2018

@0xc0170 I fixed the python 3 syntax by removing the debug statements :3

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:export-py3 branch from 501ef58 to b677ec1 Mar 1, 2018

@cmonr

A feature that also doubles as a refactor.

Neat.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 6, 2018

Build : SUCCESS

Build number : 1353
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6192/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added needs: work and removed needs: review labels Mar 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

@theotherjimmy Take a look at the Jenkins build jobs that failed. Many export jobs weren't even able to start properly.

@studavekar Should the Jenkins jobs have even started considering the export step failed?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

An example failure Jenkins log:

Started by upstream project "exporter-build-matrix" build number 1007
originally caused by:
 Started by upstream project "exporter-pipeline" build number 940
 originally caused by:
  GitHub pull request #6192 of commit b677ec1e1f34255f8cd902a52bdf9309a2b9fc1b, no merge conflicts.
[EnvInject] - Loading node environment variables.
[EnvInject] - Preparing an environment for the build.
[EnvInject] - Keeping Jenkins system variables.
[EnvInject] - Keeping Jenkins build variables.
[EnvInject] - Injecting contributions.
Building remotely on ec2-linux-exporter (i-0dc83ec12ad8df95e) (linux_exporter IAR linux_mbed_os_build ARM GCC_ARM) in workspace /builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse
[WS-CLEANUP] Deleting project workspace...
[ARCH_PRO_gnuarmeclipse] $ env bash /tmp/jenkins535171403212598430.sh
step : download sources...
build doesn't exists...
mkdir: cannot create directory ‘lockfile’: File exists
sources are been fetched by another process ...
waiting 100 sec for download to complete....
[ARCH_PRO_gnuarmeclipse] $ env bash /tmp/jenkins8274768685484174612.sh
Exporter build job
Extracting sources...
Extracting sources done..
[mbed] WARNING: Could not find mbed program in current path "/builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky".
[mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
---
usage: project.py [-h] [-m MCU] [-i IDE] [-c] [-p PROGRAM] [-n PROGRAM] [-b]
                  [-L] [-S [{matrix,ides}]] [-E] [--build BUILD_DIR]
                  [--source SOURCE_DIR] [-D MACROS] [--profile PROFILE]
                  [--update-packs] [--app-config APP_CONFIG]
project.py: error: argument -m/--mcu: invalid upper value: 'ARCH_PRO'
[mbed] ERROR: "/usr/bin/python" returned error code 2.
[mbed] ERROR: Command "/usr/bin/python -u /builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky/mbed-os/tools/project.py -i gnuarmeclipse -m ARCH_PRO --source ." in "/builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky"
---
[mbed] WARNING: Could not find mbed program in current path "/builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-sockets".
[mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
---
usage: project.py [-h] [-m MCU] [-i IDE] [-c] [-p PROGRAM] [-n PROGRAM] [-b]
                  [-L] [-S [{matrix,ides}]] [-E] [--build BUILD_DIR]
                  [--source SOURCE_DIR] [-D MACROS] [--profile PROFILE]
                  [--update-packs] [--app-config APP_CONFIG]
project.py: error: argument -m/--mcu: invalid upper value: 'ARCH_PRO'
[mbed] ERROR: "/usr/bin/python" returned error code 2.
[mbed] ERROR: Command "/usr/bin/python -u /builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-sockets/mbed-os/tools/project.py -i gnuarmeclipse -m ARCH_PRO --source ." in "/builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-sockets"
---
Completed 958 Bytes/958 Bytes (16.9 KiB/s) with 1 file(s) remaining
upload: ../../b677ec1e1f34255f8cd902a52bdf9309a2b9fc1b_exporter_build_log_ARCH_PRO_gnuarmeclipse.txt to s3://mbed-os/builds/exporter/6192/FAIL/ARCH_PRO/gnuarmeclipse/b677ec1e1f34255f8cd902a52bdf9309a2b9fc1b_exporter_build_log_ARCH_PRO_gnuarmeclipse.txt
upload of example bin failed
Build failed !!!
Build step 'Execute shell' marked build as failure
[BFA] Scanning build for known causes...
[BFA] No failure causes found
[BFA] Done. 0s
[WS-CLEANUP] Deleting project workspace...[WS-CLEANUP] done
Finished: FAILURE
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 6, 2018

@cmonr Those public logs are less than helpful.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Mar 6, 2018

@studavekar Should the Jenkins jobs have even started considering the export step failed?

Isn't it part of exporter test? Feel free to change https://github.com/ARMmbed/mbed-os/blob/master/tools/test/examples/examples.py

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 15, 2018

@theotherjimmy Still working on this PR?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 15, 2018

Yep!


OOB Is time consuming.

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:export-py3 branch from b677ec1 to 76a4c67 Mar 15, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 16, 2018

@cmonr Fixed yesterday. Review please.

@cmonr cmonr added needs: CI and removed needs: review labels Mar 16, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 16, 2018

Build : SUCCESS

Build number : 1463
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6192/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr added needs: work and removed needs: CI labels Mar 16, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 16, 2018

Fyi:

12:04:30 usage: project.py [-h] [-m MCU] [-i IDE] [-c] [-p PROGRAM] [-n PROGRAM] [-b]
12:04:30                   [-L] [-S [{matrix,ides}]] [-E] [--build BUILD_DIR]
12:04:30                   [--source SOURCE_DIR] [-D MACROS] [--profile PROFILE]
12:04:30                   [--update-packs] [--app-config APP_CONFIG]
12:04:30 project.py: error: argument -m/--mcu: invalid upper value: 'ARCH_PRO'
12:04:30 [mbed] ERROR: "/usr/bin/python" returned error code 2.
12:04:30 [mbed] ERROR: Command "/usr/bin/python -u /builds/ws/exporter-build-matrix/1108/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky/mbed-os/tools/project.py -i gnuarmeclipse -m ARCH_PRO --source ." in "/builds/ws/exporter-build-matrix/1108/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky"
12:21:32 usage: project.py [-h] [-m MCU] [-i IDE] [-c] [-p PROGRAM] [-n PROGRAM] [-b]
12:21:32                   [-L] [-S [{matrix,ides}]] [-E] [--build BUILD_DIR]
12:21:32                   [--source SOURCE_DIR] [-D MACROS] [--profile PROFILE]
12:21:32                   [--update-packs] [--app-config APP_CONFIG]
12:21:32 project.py: error: argument -m/--mcu: invalid upper value: 'TY51822R3'
12:21:32 [mbed] WARNING: Could not find mbed program in current path "C:\builds\ws\exporter-build-matrix\1108\TY51822R3_iar\sources\examples\mbed-os-example-blinky".
12:21:32 [mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 16, 2018

I'll rebase. Just a sec.

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:export-py3 branch from 76a4c67 to 14255ca Mar 16, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 16, 2018

Hmmmm. still present.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 16, 2018

Because a type was just str.upper....

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:export-py3 branch from 28e8ea5 to e5f5a3b Mar 16, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 16, 2018

Build : SUCCESS

Build number : 1468
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6192/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 16, 2018

Ignore this (^^^) test. It's from the first build command.

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 4840e4d into ARMmbed:master Mar 19, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment