New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue for M33 core #6214

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
5 participants
@tkaman
Contributor

tkaman commented Feb 26, 2018

Fix typo in irq_armv8mml.S

Signed-off-by: Tamas Kaman tamas.kaman@arm.com

Description

Because of this typo building this assembly file failed

For testing I simply run the build again and the build error was gone.

Pull request type

  • Fix
Build issue for M33 core
Fix typo in irq_armv8mml.S

Signed-off-by: Tamas Kaman <tamas.kaman@arm.com>

@cmonr cmonr requested a review from deepikabhavnani Feb 27, 2018

@cmonr cmonr added the needs: review label Feb 27, 2018

@cmonr cmonr requested a review from SenRamakri Feb 27, 2018

@cmonr

Maybe this is GitHub's online diff tool acting weird, but is the only difference a + at the beginning of the line?

@deepikabhavnani

Looks good to me 👍

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 27, 2018

/morph build

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Feb 27, 2018

Maybe this is GitHub's online diff tool acting weird, but is the only difference a + at the beginning of the line?

Yes this + went in somehow

@cmonr

cmonr approved these changes Feb 27, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Feb 27, 2018

@cmonr - Can you try restarting the failing CI job?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 27, 2018

@deepikabhavnani Unfortunately I don't think I'm able to restart continuous-integration/jenkins/pr-head remotely. Will be looking into it first thing tomorrow assuming it's still an issue then.

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 27, 2018

Build : SUCCESS

Build number : 1267
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6214/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr cmonr added needs: CI and removed needs: review labels Feb 27, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 27, 2018

Simply noting for the PR's history, pr-head is still experiencing issues...

@adbridge adbridge merged commit 8add292 into ARMmbed:master Feb 28, 2018

17 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment