New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl8195am: fix ARM section error #6226

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
6 participants
@M-ichae-l
Contributor

M-ichae-l commented Feb 27, 2018

Description

fix section error, ARM compiler uses IRAM1.bss to calculate the heap size

fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler

rebase update for #6061

Pull request type

  • Fix
mbed-os_ci-test-fixed_rtl8195am
fix section error, ARM compiler uses IRAM1.bss to calculate the heap size

fix conflict of _memset between Ameba's library and ARM compiler's library, use standard memset() instead of _memset() in case of ARM compiler
@@ -29,9 +29,6 @@ LR_IRAM 0x10007000 (0x70000 - 0x7000) {
*libc.a (+RW)
*(.sdram.data*)
*lib_peripheral_mbed_arm.ar (+RW)
}
RW_IRAM2 +0 UNINIT FIXED {

This comment has been minimized.

@cmonr

cmonr Feb 27, 2018

Contributor

Is the main thing that this PR is doing is replacing RAM2 block usage with the RAM1 block?

This comment has been minimized.

@prashantrar

prashantrar Feb 27, 2018

Contributor

There is some part of the memory at the end of RAM2 which contains data that we donot want to touch throughout the lifecycle of the program. RAM2 block usage might create a scenario where the memory might reach the addresses that we donot wish to touch, hence we have replaced RAM2 block usage with RAM1.

@@ -17,6 +17,10 @@
#include "analogin_api.h"
#include "analogin_ext.h"
#ifdef CONFIG_MBED_ENABLED

This comment has been minimized.

@cmonr

cmonr Feb 27, 2018

Contributor

What are these new #ifdefs enabling that wasn't enabled before?

This comment has been minimized.

@prashantrar

prashantrar Feb 27, 2018

Contributor

Our platform has its own std libraries that are defined under platform_stdlib.h, some of these define are modified to support our specific realtek platform and are different from the original stdlib.h hence we have this define enabled here.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 27, 2018

Build : SUCCESS

Build number : 1275
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6226/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 27, 2018

/morph export-build

2 similar comments
@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 27, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 27, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

/morph export-build
/morph mbed2-build

@cmonr cmonr added needs: CI and removed needs: review labels Mar 6, 2018

@cmonr

cmonr approved these changes Mar 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

@0xc0170 You might need to re-kick these builds.

@studavekar Morph restart appears to not have work this time.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

/morph export-build

2 similar comments
@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

/morph export-build

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Mar 6, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 7, 2018

/morph mbed2-build

@M-ichae-l M-ichae-l referenced this pull request Mar 7, 2018

Closed

rtl8195am - fix gpio toggle slow #6289

1 of 5 tasks complete
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 7, 2018

/morph mbed2-build

@0xc0170 0xc0170 changed the title from mbed-os_ci-test-fixed_rtl8195am to rtl8195am: fix ARM section error Mar 7, 2018

@0xc0170 0xc0170 merged commit 4e7ad0d into ARMmbed:master Mar 8, 2018

17 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Mar 8, 2018

@M-ichae-l M-ichae-l deleted the M-ichae-l:mbed-os_ci-test-fixed_rtl8195am branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment