New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system_reset call #6230

Merged
merged 3 commits into from Mar 1, 2018

Conversation

Projects
None yet
5 participants
@bulislaw
Member

bulislaw commented Feb 27, 2018

Description

  • Add official Mbed API for reseting the system using CMSIS call.
  • Add tests

Pull request type

  • Feature
* @return true if a target can go to deepsleep, false otherwise
*/
bool sleep_manager_can_deep_sleep(void);
#warning mbed_sleep.h has been replaced by mbed_power_mgmt.h, please update to mbed_power_mgmt.h [since mbed-os-5.9]

This comment has been minimized.

@cmonr

cmonr Feb 27, 2018

Contributor

Just wanted to mention that I like how early this PR is 👍

@@ -18,7 +18,7 @@
#ifndef MBED_OLD_SLEEP_H
#define MBED_OLD_SLEEP_H
#warning sleep.h has been replaced by mbed_sleep.h, please update to mbed_sleep.h [since mbed-os-5.3]
#include "platform/mbed_sleep.h"
#warning sleep.h has been replaced by mbed_power_mgmt.h, please update to mbed_power_mgmt.h [since mbed-os-5.3]

This comment has been minimized.

@cmonr

cmonr Feb 27, 2018

Contributor

Is this suppose to say since mbed-os-5.9? Or is this because sleep came before mbed_sleep?

This comment has been minimized.

@bulislaw

bulislaw Feb 28, 2018

Member

Good catch!

@bulislaw bulislaw referenced this pull request Feb 28, 2018

Merged

System reset docs #424

1 of 2 tasks complete

@bulislaw bulislaw force-pushed the bulislaw:system_reset branch 3 times, most recently from 59cdbd9 to 5782a0f Feb 28, 2018

@bulislaw

This comment has been minimized.

Member

bulislaw commented Feb 28, 2018

@cmonr I've updated the warnings to 5.8 as the PR is marked for 5.8-rc1

@adbridge

This comment has been minimized.

Contributor

adbridge commented Feb 28, 2018

@bulislaw looks like this is also going to need a rebase. You may need to chase @SenRamakri for the review as @0xc0170 is out the rest of this week. Is there anyone else that could review? It is starting to get very close to not making it into 5.8....

@bulislaw bulislaw force-pushed the bulislaw:system_reset branch from 5782a0f to 73b0546 Feb 28, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 28, 2018

@bulislaw Looks like there's still one lingering travis issue. Once it's all green, we can start the CI build.

@bulislaw

This comment has been minimized.

Member

bulislaw commented Feb 28, 2018

@cmonr @SenRamakri I've removed conflicting (and identical) system_reset implementation from ATMEL.

@cmonr

cmonr approved these changes Feb 28, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 28, 2018

@bulislaw I like that the removed code was completely identical.

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Feb 28, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 28, 2018

Build : SUCCESS

Build number : 1307
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6230/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 1, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Mar 1, 2018

@SenRamakri Please re-review and confirm you are happy with the changes

@cmonr cmonr merged commit 9ddb092 into ARMmbed:master Mar 1, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the needs: review label Mar 1, 2018

@scartmell-arm scartmell-arm referenced this pull request Mar 1, 2018

Merged

Add optional tracing to sleep manager lock/unlock #6142

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment