New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Crash dump formatting issues and adding more info to crash dump #6257

Merged
merged 2 commits into from Mar 8, 2018

Conversation

Projects
None yet
7 participants
@SenRamakri
Contributor

SenRamakri commented Mar 2, 2018

This fixes some formatting issues in crash dump and also adds more info like return stack info, privilege level and mode to the crash dump.

@SenRamakri SenRamakri requested review from kegilbert, 0xc0170 and studavekar Mar 2, 2018

@kegilbert

LGTM, thanks for the fix!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 5, 2018

Based on the commit msg: Fix line feed issues and add mode info to crash dump - these should be separate commits ? One fixing , another adding mode info.

A fix commit should contain info how it fixes it and why (might be obvious when they are split).

@0xc0170 0xc0170 added the needs: work label Mar 5, 2018

@0xc0170

See my comment above

@SenRamakri SenRamakri force-pushed the SenRamakri:sen_FaultHandlerFixes branch from bf71386 to 72f45b8 Mar 5, 2018

@SenRamakri

This comment has been minimized.

Contributor

SenRamakri commented Mar 5, 2018

@0xc0170 - I have split the commits into 2 commits - One to fix the formatting and other to add more info to crash dump.

@0xc0170

0xc0170 approved these changes Mar 7, 2018

@0xc0170 0xc0170 added needs: review and removed needs: work labels Mar 7, 2018

@SenRamakri

This comment has been minimized.

Contributor

SenRamakri commented Mar 7, 2018

@kegilbert and @studavekar - Can you please re-review this PR?

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Mar 7, 2018

LGTM 👍

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 7, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 7, 2018

Build : SUCCESS

Build number : 1382
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6257/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 8, 2018

@SenRamakri SenRamakri referenced this pull request Mar 8, 2018

Closed

Fix issue in fault handler #6302

1 of 1 task complete
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 8, 2018

@0xc0170 Why did you not just merge it?

@theotherjimmy theotherjimmy merged commit f67fe4a into ARMmbed:master Mar 8, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
@adbridge

This comment has been minimized.

Contributor

adbridge commented Mar 14, 2018

Functionality came into 5.8 so fix should also do so

@SenRamakri

This comment has been minimized.

Contributor

SenRamakri commented Mar 14, 2018

As @adbridge mentioned, please take in this for 5.8 as its very much localized and should not impact any other area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment