New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittests fixed #6268

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
7 participants
@AnttiKauppila
Contributor

AnttiKauppila commented Mar 5, 2018

Description

nsapi_socket_t errors fixed in unittests
No code changes done, so should be trivial merge

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change
@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Mar 5, 2018

@jarvte, @kjbracey-arm Can you review this

@jarvte

jarvte approved these changes Mar 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 5, 2018

nsapi_socket_t errors fixed in unittests

Can you update your commit msg and describe the fix (the line here in quote is actually what can be there). A commit msg like "Cellular tests: fix socket errors" and paragraph above would describe a bit more if needed.

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Mar 5, 2018

@0xc0170 Good suggestion Martin, this is now fixed

@0xc0170

0xc0170 approved these changes Mar 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 5, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 5, 2018

Build : SUCCESS

Build number : 1335
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6268/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr cmonr added the needs: CI label Mar 5, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

I like trivial changes.

@cmonr cmonr merged commit 772a857 into ARMmbed:master Mar 6, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
@adbridge

This comment has been minimized.

Contributor

adbridge commented Mar 14, 2018

Cellular only came in for 5.8 it should have been fairly obvious therefore that this couldn't be backported to 5.7....

@mbed-ci

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment