Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Cellular: BC95 echo test fixes #6291
Issues fixed: getting host by name, socket send/recv iterations, SIM state retrieval. Additionaly, cellular APN lookup decision logic is fixed.
These issues were found when testing BC95 against https://github.com/ARMmbed/mbed-os-example-cellular.
Pull request type
QUECTEL_BC95_CellularSIM addition is needed in order to get this module running past the SIM state checking. AT+CPIN? used in base class: AT_CellularSIM::get_sim_state is not supported AT command for this module. So when I took in use latest mbed-os-example-cellular and mbed-os, these were the changes I needed to do in order to get the echo test pass.
The debug info I just found it to be useful while doing and testing these changes, that's why I added them at this point.
It is true that three different issues are addressed in this one commit(socket send/recv, SIM state, APN lookup logic). But all three were necessary to get example app's echo test pass. Do I have to generate new pull request with separate commits or will I just keep this in mind for future pull requests?
You can rebase/amend this commit here, should be straightforward to split them.
Mar 8, 2018
Build number : 1390
Build number : 1045