New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: BC95 echo test fixes #6291

Merged
merged 5 commits into from Mar 20, 2018

Conversation

Projects
None yet
5 participants
@mirelachirica
Contributor

mirelachirica commented Mar 7, 2018

Description

Issues fixed: getting host by name, socket send/recv iterations, SIM state retrieval. Additionaly, cellular APN lookup decision logic is fixed.

These issues were found when testing BC95 against https://github.com/ARMmbed/mbed-os-example-cellular.

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change
@mirelachirica

This comment has been minimized.

Contributor

mirelachirica commented Mar 7, 2018

@jarvte please review this

@0xc0170 0xc0170 requested a review from jarvte Mar 7, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 7, 2018

Are all fixes related thus lead to one commit ? I can see addition here QUECTEL_BC95_CellularSIM that looks like a new logical change. Adding some debug info, another one.

@jarvte

jarvte approved these changes Mar 7, 2018

@mirelachirica

This comment has been minimized.

Contributor

mirelachirica commented Mar 7, 2018

QUECTEL_BC95_CellularSIM addition is needed in order to get this module running past the SIM state checking. AT+CPIN? used in base class: AT_CellularSIM::get_sim_state is not supported AT command for this module. So when I took in use latest mbed-os-example-cellular and mbed-os, these were the changes I needed to do in order to get the echo test pass.

The debug info I just found it to be useful while doing and testing these changes, that's why I added them at this point.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 7, 2018

@mirelachirica Thanks, my point was only about having it squashed into one commit (why are these in one commit - if all are related and fixing the same thing OK, otherwise use separate commits ).

@mirelachirica

This comment has been minimized.

Contributor

mirelachirica commented Mar 8, 2018

It is true that three different issues are addressed in this one commit(socket send/recv, SIM state, APN lookup logic). But all three were necessary to get example app's echo test pass. Do I have to generate new pull request with separate commits or will I just keep this in mind for future pull requests?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 8, 2018

It is true that three different issues are addressed in this one commit(socket send/recv, SIM state, APN lookup logic). But all three were necessary to get example app's echo test pass. Do I have to generate new pull request with separate commits or will I just keep this in mind for future pull requests?

You can rebase/amend this commit here, should be straightforward to split them.

@mirelachirica mirelachirica force-pushed the mirelachirica:bc95_echotest_fixes branch from 1db6e19 to be95f47 Mar 8, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 8, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 8, 2018

Build : SUCCESS

Build number : 1390
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6291/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

0xc0170 approved these changes Mar 9, 2018

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 9, 2018

@mirelachirica

This comment has been minimized.

Contributor

mirelachirica commented Mar 9, 2018

ARM internal ref: IOTCELL-603, IOTCELL-649, IOTCELL-665

QUECTEL_BC95_CellularSIM(ATHandler &atHandler);
virtual ~QUECTEL_BC95_CellularSIM();
public: //from CellularSIM

This comment has been minimized.

@cmonr

cmonr Mar 15, 2018

Contributor

Funky. Is there a specific reason why public: is declared twice?

This comment has been minimized.

@mirelachirica

mirelachirica Mar 20, 2018

Contributor

Not really. It is copied from other modules where it is used for specifying in comments the different interfaces the class is implementing, but of course comment alone would be enough.

using namespace mbed;
QUECTEL_BC95_CellularSIM::QUECTEL_BC95_CellularSIM(ATHandler &atHandler) : AT_CellularSIM(atHandler)
{

This comment has been minimized.

@cmonr

cmonr Mar 15, 2018

Contributor

Is there a reason the constructor and destructor are empty?

This comment has been minimized.

@mirelachirica

mirelachirica Mar 20, 2018

Contributor

The "empty" constructor is needed for passing atHandler to base AT_CellularSIM.
But empty destructor is not needed.

@cmonr cmonr added needs: review and removed ready for merge labels Mar 15, 2018

@cmonr cmonr merged commit 7b2ee2d into ARMmbed:master Mar 20, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment