New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCUXpresso: Fix test failures seen with ci-test shield #6310

Merged
merged 3 commits into from Mar 15, 2018

Conversation

Projects
None yet
4 participants
@mmahadevan108
Contributor

mmahadevan108 commented Mar 8, 2018

A. Enable internal pullup resistor for sda and scl lines.
B. Update the implmentation for byte read and write

  1. Start function: Issue repeat start when bus is busy
  2. Byte write function: Do not call SDK function as this does
    not work for some of the Kinetis device
  3. Byte read function: Do not call SDK function as this would
    issue a START and STOP signal which is not required for
    I2C byte functions
    C. Fix K82F I2C ci-test shield failure

Ran the I2C ci-test shield tests to confirm

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Mar 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 9, 2018

@mmahadevan108 👍 Thanks for fixes

Looking at the changes, should A-C be separate commits? From the code changes and the description I would say yes, to separate these 3 fixes, and address each one in the own commit

Please use pull request type section in the pull request , this info is required. I updated it to add it back there.

@0xc0170

Should it be 3 separate commits addressing each issue in this PR

mmahadevan108 added some commits Mar 9, 2018

K82F: Fix I2C test failures seen with ci-test shield
I2C3 clock define was missing. I2C3 is connected to the Arduino
connector which is used by the ci-test shield

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
MCUXpresso: Enable I2C SDA & SCL pins internal pullup resistors
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
MCUXpresso: Update the I2C implmentation for byte read and write
1. Start function: Issue repeat start when bus is busy
2. Byte write function: Do not call SDK function as this does
   not work for some of the Kinetis device
3. Byte read function: Do not call SDK function as this would
   issue a START and STOP signal which is not required for
   I2C byte functions

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Fix_K82F_I2C branch from c097bfd to 5230bca Mar 9, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Mar 9, 2018

@0xc0170. Thanks for the suggestion, I have split this into 3 commits.

@0xc0170

0xc0170 approved these changes Mar 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 9, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 9, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 9, 2018

Build : SUCCESS

Build number : 1402
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6310/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 12, 2018

@cmonr cmonr merged commit 842a86a into ARMmbed:master Mar 15, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 15, 2018

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Fix_K82F_I2C branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment