New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIMXRT: define PullUp default value #6328

Merged
merged 1 commit into from Mar 12, 2018

Conversation

Projects
None yet
5 participants
@0xc0170
Member

0xc0170 commented Mar 12, 2018

Description

This target defines few PullUp values, one should be defined to be PullUp that
an application can use. We use the same value as PullDefault

@ARMmbed/team-nxp Please review

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change
MIMXRT: define PullUp default value
This target defines few PullUp values, one should be defined to be PullUp that
an application can use. We use the same value as PullDefault
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 12, 2018

This unblocks #6304

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 12, 2018

/morph build

@adbridge

This comment has been minimized.

Contributor

adbridge commented Mar 12, 2018

Because this is needed for #6304 which in turn is needed for 5.8-rc2 we can take this without review from the NXP team. At the moment there just needs to be a value defined. The specific value can always be patched in 5.8.1 if necessary.

@adbridge adbridge self-requested a review Mar 12, 2018

@adbridge

LGTM

@adbridge adbridge added needs: CI and removed needs: review labels Mar 12, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 12, 2018

Build : SUCCESS

Build number : 1415
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6328/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 12, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 12, 2018

/morph test

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 12, 2018

K64F devices timed out. Will restart test in a bit.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 12, 2018

/morph test

@maclobdell

This comment has been minimized.

Contributor

maclobdell commented Mar 12, 2018

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 12, 2018

Flash cache test issue came up...

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr removed the needs: CI label Mar 12, 2018

@cmonr cmonr merged commit 205b2ed into ARMmbed:master Mar 12, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment