New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: add callback API #6329

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
6 participants
@TeemuKultala
Contributor

TeemuKultala commented Mar 12, 2018

Description

Network connection status callback API added

Pull request type

  • Fix
@TeemuKultala

This comment has been minimized.

Contributor

TeemuKultala commented Mar 12, 2018

@AnttiKauppila @juhoeskeli please review

@0xc0170 0xc0170 added the needs: CI label Mar 12, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 12, 2018

/morph build

@0xc0170 0xc0170 changed the title from callback API added to Cellular: add callback API Mar 12, 2018

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Mar 12, 2018

Even if this looks like an API change it is not. AT_CellularNetwork already implements these functions, and these functions are inherited from NetworkInterface. CellularNetwork is between of these classes and should inherit same functions.

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 12, 2018

Build : SUCCESS

Build number : 1414
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6329/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 12, 2018

Even if this looks like an API change it is not. AT_CellularNetwork already implements these functions, and these functions are inherited from NetworkInterface. CellularNetwork is between of these classes and should inherit same functions.

This means this is a fix, not a feature as stated above

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

cmonr approved these changes Mar 15, 2018

@cmonr cmonr merged commit 92bbdbb into ARMmbed:master Mar 15, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 15, 2018

@TeemuKultala TeemuKultala deleted the TeemuKultala:callback_changes branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment