New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected lwip adaptation TCP flagging #6333

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
5 participants
@mikaleppanen
Contributor

mikaleppanen commented Mar 12, 2018

Description

Corrected LWIP TCP flagging. Some TCP code was not flagged which caused compilation error in UDP only configuration.

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

@0xc0170 0xc0170 requested a review from kjbracey-arm Mar 12, 2018

@@ -1147,9 +1147,11 @@ static nsapi_error_t mbed_lwip_socket_listen(nsapi_stack_t *stack, nsapi_socket_
{
struct lwip_socket *s = (struct lwip_socket *)handle;
#if LWIP_TCP

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Mar 13, 2018

Contributor

To further reduce code size, I reckon the entirety of both these functions probably should be wrapped in the #if so they just return "unsupported" if !TCP.

This comment has been minimized.

@mikaleppanen

mikaleppanen Mar 13, 2018

Contributor

Updated flagging.

@mikaleppanen mikaleppanen force-pushed the mikaleppanen:lwip_tcp_flag_corr branch from bcec39f to af29734 Mar 13, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 13, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 15, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 15, 2018

Build : SUCCESS

Build number : 1439
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6333/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 16, 2018

CI issue: NRF52 flash cache test

/morph test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 16, 2018

CI issue: ARM network licenses could not be checked out during build.

Restarting.
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 19, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 0b7a9a9 into ARMmbed:master Mar 20, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment