New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 LPTICKER : optimize RTC wake up timer init #6370

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
5 participants
@jeromecoutant
Contributor

jeromecoutant commented Mar 15, 2018

Description

Division in a while loop is removed

You can read the study here:
#6272 (comment)

@marcemmers

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change
if (HAL_RTCEx_SetWakeUpTimer_IT(&RtcHandle, 0xFFFF & WakeUpCounter, WakeUpClock[DivIndex - 1]) != HAL_OK) {
error("rtc_set_wake_up_timer init error (%d)\n", DivIndex);
if (HAL_RTCEx_SetWakeUpTimer_IT(&RtcHandle, (uint32_t)WakeUpCounter, WakeUpClock) != HAL_OK) {
error("rtc_set_wake_up_timer init error");

This comment has been minimized.

@marcemmers

marcemmers Mar 15, 2018

Contributor

Bit of nitpicking but you forgot the '\n' in the error.

Otherwise looks ok!

STM32 LPTICKER : optimize RTC wake up timer init
Division in a while loop is removed

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_LPT_RTC_OPTIM branch from 281ac85 to 882f331 Mar 15, 2018

@cmonr

cmonr approved these changes Mar 19, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 19, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Mar 19, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 19, 2018

Build : SUCCESS

Build number : 1482
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6370/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 20, 2018

@cmonr cmonr merged commit d7dfab5 into ARMmbed:master Mar 20, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 20, 2018

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_LPT_RTC_OPTIM branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment