New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32L4 ADC correct internal channel management #6412

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
4 participants
@jeromecoutant
Contributor

jeromecoutant commented Mar 21, 2018

Description

Issue detected in #6398
Only 1 internal channel could be configured which was wrong.

@maskedw

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 21, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 21, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 21, 2018

Build : SUCCESS

Build number : 1518
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6412/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr

LGTM, just some questions.

/* Configuration of common ADC parameters */
/* If the requested internal measurement path has already been enabled, */
/* bypass the configuration processing. */
if (( (sConfig->Channel == ADC_CHANNEL_TEMPSENSOR) &&

This comment has been minimized.

@cmonr

cmonr Mar 21, 2018

Contributor

Interesting. So configuration of the internal channels doesn't require that the ADC be in RESET mode?

This comment has been minimized.

@jeromecoutant

jeromecoutant Mar 22, 2018

Contributor

configuration of the internal channels doesn't require that the ADC be in RESET mode?

Yes, ADC driver team explained me that restriction is no more valid since last reference manual version.
Official correction will come in the next cube release.

/* of the common group are disabled. */
if ((ADC_IS_ENABLE(hadc) == RESET) &&
(ADC_ANY_OTHER_ENABLED(hadc) == RESET) )
if (ADC_TEMPERATURE_SENSOR_INSTANCE(hadc))

This comment has been minimized.

@cmonr

cmonr Mar 21, 2018

Contributor

Does this imply that ADC parameters can now be changed without all ADCs needing to be in reset (per the deleted comment)?

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 22, 2018

@cmonr cmonr merged commit 7c272fa into ARMmbed:master Mar 22, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 22, 2018

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_L4_ADC branch Mar 22, 2018

@jeromecoutant jeromecoutant referenced this pull request May 23, 2018

Merged

STM32 ADC update #6987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment