New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl8195am: fix LogUART Tx interrupt crash #6415

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
7 participants
@M-ichae-l
Contributor

M-ichae-l commented Mar 21, 2018

Description

  • fix for issue #6358

  • add Mask & UnMask Tx FIFO empty interrupt for LogUart

  • fix LogUart interrupt enable

  • fix LogUart interrupt handler

  • coding style fix

Pull request type

  • Fix
rtl8195am: fix LogUART Tx interrupt crash
add Mask & UnMask Tx FIFO empty interrupt for LogUart
fix LogUart interrupt enable
fix LogUart interrupt handler
coding style fix
@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Mar 21, 2018

I verified that this fixes the issue #6358

@0xc0170 0xc0170 added the needs: CI label Mar 21, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 21, 2018

Build : SUCCESS

Build number : 1515
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6415/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 22, 2018

/morph test

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Mar 23, 2018

Failure :

1521672512.14][CONN][RXD] >>> Running case #1: '500us lp_ticker'...
[1521672512.14][CONN][INF] found KV pair in stream: {{__testcase_name;1s lp_ticker deepsleep}}, queued...
[1521672512.29][CONN][INF] found KV pair in stream: {{__testcase_start;500us lp_ticker}}, queued...
[1521672512.36][CONN][RXD] :76::FAIL: Values Not Within Delta 600 Expected 500 Was 2713
[1521672512.36][CONN][RXD] >>> '500us lp_ticker': 0 passed, 1 failed with reason 'Test Cases Failed'
[1521672512.36][CONN][RXD] 

NUCLEO_F401RE-ARM.features-tests-filesystem-util_block_device.features-tests-filesystem-util_block_device
NUCLEO_F401RE-GCC_ARM.tests-mbed_platform-singletonptr.tests-mbed_platform-singletonptr
NUCLEO_F401RE-IAR.features-frameworks-utest-tests-unit_tests-case_async_validate.features-frameworks-utest-tests-unit_tests-case_async_validate

Re-trigging test

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 23, 2018

@cmonr cmonr merged commit 26e1275 into ARMmbed:master Mar 23, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 23, 2018

@KariHaapalehto

This comment has been minimized.

Contributor

KariHaapalehto commented Mar 26, 2018

This pull request contains incompatible white space changes, that broke rebasing.

06:16:42  create mode 100644 targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TARGET_MTB_ADV_WISE_1530/PinNames.h
06:16:42  create mode 100644 targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TARGET_MTB_ADV_WISE_1530/system_clock.c
06:16:42 + git checkout PR_6423
06:16:42 error: Your local changes to the following files would be overwritten by checkout:
06:16:42 	targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/serial_api.c
06:16:42 Please, commit your changes or stash them before you can switch branches.
06:16:42 Aborting
06:16:42 Build step 'Execute shell' marked build as failure
06:16:42 Archiving artifacts

@0xc0170 @cmonr @M-ichae-l @SeppoTakalo
Please correct this immediatilly, this is breaking CI

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 26, 2018

Already proposed, waiting for CI and will be fixed asap

@M-ichae-l M-ichae-l deleted the M-ichae-l:rtl8195am-fix-logUART-Tx-interrupt-crash- branch Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment