New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwIP: fix some IPv6 errors, eg TCP keepalive #6416

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
6 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Mar 21, 2018

Description

Glue code was inspecting lwIP's netconn type, checking directly for NETCONN_UDP and NETCONN_TCP.

Unfortunately the type byte has some flag bits like "IPv6", which means the tests fail if it's an IPv6 socket. So, for example, TCP socket options were rejected for IPv6.

Add the necessary NETCONNTYPE_GROUP macros to fix this.

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change
lwIP: fix some IPv6 errors, eg TCP keepalive
Glue code was inspecting lwIP's netconn "type", checking directly for
NETCONN_UDP and NETCONN_TCP.

Unfortunately the type byte has some flag bits like
"IPv6", which means the tests fail if it's an IPv6 socket. So, for
example, TCP socket options were rejected for IPv6.

Add the necessary NETCONNTYPE_GROUP macros to fix this.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 23, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 23, 2018

Build : SUCCESS

Build number : 1550
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6416/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 24, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 57b48f6 into ARMmbed:master Mar 26, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 26, 2018

@kjbracey-arm kjbracey-arm deleted the kjbracey-arm:lwip_netconntype_fix branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment