New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct get_config imports #6419

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Mar 21, 2018

mbed compile --config currently fails for me on master with:

Traceback (most recent call last):
  File "/home/jimmy/src/armmbed/fat-fs/mbed-os/tools/get_config.py", line 31, in <module>
    from config import Config
  File "/home/jimmy/src/armmbed/mbed-os/tools/config/__init__.py", line 33, in <module>
    from ..utils import json_file_to_dict, intelhex_offset, integer
ValueError: Attempted relative import beyond toplevel package

This is related to the incorrect path to the config import

@cmonr cmonr added the needs: review label Mar 21, 2018

@cmonr

cmonr approved these changes Mar 21, 2018

LGTM.

@cmonr cmonr added needs: CI and removed needs: review labels Mar 21, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 21, 2018

Build : SUCCESS

Build number : 1522
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6419/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 22, 2018

F429ZI timed out...

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 4a5f4aa into ARMmbed:master Mar 23, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment