New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all deprecated exporters #6441

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
7 participants
@theotherjimmy
Contributor

theotherjimmy commented Mar 23, 2018

[X] Breaking change

@cmonr

Tiny change, nice!

But is there any particular reason why these exporters are considered deprecated? Will users receive a deprecation warning before 5.9?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 23, 2018

@cmonr They have been receiving a deprecation warning for a year.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 23, 2018

They're deprecated because no one supports them.

@cmonr cmonr requested a review from 0xc0170 Mar 23, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Mar 23, 2018

@cmonr

cmonr approved these changes Mar 23, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 23, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 23, 2018

Build : SUCCESS

Build number : 1549
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6441/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 24, 2018

@0xc0170

The only one I would question is simplicity. @stevew817

@sg-

This comment has been minimized.

Member

sg- commented Mar 24, 2018

Have we publicly messaged that these will be deprecated? Have we messaged to partners who contributed these?

@sg-

Have we publicly messaged that these will be deprecated? Have we messaged to partners who contributed these?

Rejected until there is a confirmation of this having happened.

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Mar 26, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 26, 2018

@sg- We messaged partners that own these exporters as I added the deprecation notice (that claims 5.6!). That's how we got MCUXpresso.

@sg-

This comment has been minimized.

Member

sg- commented Mar 26, 2018

I've confirmed with @stevew817 but @maclobdell and @mmahadevan108 are doing a diff between support of boards for MCUXpresso, KDS and LPCXpresso. I'll approve once they do.

@sg- sg- requested a review from maclobdell Mar 26, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Mar 26, 2018

Thanks for doing that leg work @sg-.

@sg-

sg- approved these changes Apr 16, 2018

@maclobdell @mmahadevan108 Did you determine if this is safe? If not, y'all can block the PR by rejecting the changes.

@cmonr cmonr added needs: review and removed needs: work labels Apr 16, 2018

@maclobdell

maclobdell approved these changes Apr 17, 2018 edited

NXP confirms that it is okay to deprecate support for LPCXpresso and Kinetis Design Studio. Users have been warned of this coming since Mbed OS 5.5. All key devices are supported now by MCUXpresso.

@0xc0170 0xc0170 added the needs: CI label Apr 17, 2018

@0xc0170 0xc0170 removed the needs: review label Apr 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 17, 2018

Thanks for all the feedback!

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 17, 2018

Build : SUCCESS

Build number : 1774
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6441/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 18, 2018

@0xc0170 0xc0170 merged commit 7aa293b into ARMmbed:master Apr 18, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10352 cycles (+1522 cycles)
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment