[feature-nrf528xx] NRF52 serial bug fix and serial_free implementation #6491
Conversation
serial_putc didn't work when called with interrupts disabled.
Instance counter keeps track of how many objects have been initialized and freed. On the first object the instance is enabled and on the last object the instance is disabled.
cmonr
left a comment
cmonr
left a comment
There was a problem hiding this comment.
LGTM aside for a few questions.
| nordic_nrf5_uart_state[instance].usage_counter++; | ||
|
|
||
| /* Enable instance on first usage. */ | ||
| if (nordic_nrf5_uart_state[instance].usage_counter == 1) { |
There was a problem hiding this comment.
Why does each peripheral instance have a usage counter? Shouldn't the usage counter be a part of the bank of peripherals?
There was a problem hiding this comment.
You enable/disable each instance separately.
| { | ||
| MBED_ASSERT(obj); | ||
|
|
||
| #if DEVICE_SERIAL_ASYNCH |
There was a problem hiding this comment.
The need for this feels very strange.
Is this to say that obj can take multiple serial_t types?
There was a problem hiding this comment.
Yes, all obj across the HAL is like that: https://github.com/ARMmbed/mbed-os/blob/master/hal/serial_api.h#L85-L101
| /* Take ownership and configure UART if necessary. */ | ||
| nordic_nrf5_serial_configure(obj); | ||
|
|
||
| /** |
|
/morph build |
1 similar comment
|
/morph build |
Build : SUCCESSBuild number : 1620 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1249 |
Test : SUCCESSBuild number : 1402 |
4 participants
Description
Fixed a bug preventing serial_putc from working when interrupts were disabled.
Added resource counting and implemented missing serial_free function.
Pull request type
[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change