New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude files like `.main.cpp` from builds #6530

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Apr 3, 2018

Description

It was possible before to compile files starting with a ., I have removed that capability. I also stopped recording the base path of files we are not adding to the build.

Resolves #5331

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr requested review from screamerbg and cmonr Apr 3, 2018

@cmonr

cmonr approved these changes Apr 3, 2018

👍

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 3, 2018

/morph build

@cmonr cmonr added the needs: CI label Apr 3, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 3, 2018

Build : SUCCESS

Build number : 1652
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6530/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Apr 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 4, 2018

It was possible before to compile files starting with a ., I have removed that capability. I also stopped recording the base path of files we are not adding to the build.

What is the reason for this change? .main.cpp is removed and how main.cpp gets in?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 4, 2018

@0xc0170 I don't understand either of your questions. I did not remove any files.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 4, 2018

@0xc0170 The issue isn't specific to .main.cpp, @theotherjimmy only used it as an example.

Some editors sometimes store temporary files whilst editing files, and they generally have a .<filename> format. As an example, files edited by vim generally have a .<filename>.swp syntax.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 5, 2018

@cmonr Thanks for the explanation, clear

@0xc0170

0xc0170 approved these changes Apr 5, 2018

@theotherjimmy theotherjimmy merged commit 192a8e5 into ARMmbed:master Apr 6, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9107 cycles (+180 cycles)
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment