New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent compiling with unsupported compilers #6540

Merged
merged 2 commits into from Apr 24, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Apr 4, 2018

Description

Before this change it is possible to compile with a compiler that a
device port does not support. Afterwards it will not be.

It is possible to override the supported toolchains in the application
configuration and compile with the unsupported toolchain after this change.

Resolves #5109

Pull request type

[✓] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@theotherjimmy theotherjimmy requested a review from bridadan Apr 4, 2018

@bridadan

Looks good, with a few follow up questions/potential tasks:

  1. Might be a good idea to add a test for target_supports_toolchain, specifically for the ARM case.
  2. In the NotSupportedException, do we want to also state that "It is possible to override the supported toolchains in the application configuration and compile with the unsupported toolchain"?

@0xc0170 0xc0170 added the needs: work label Apr 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 5, 2018

Please review travis CI, failures related

@theotherjimmy theotherjimmy dismissed stale reviews from 0xc0170 and bridadan via c0410d7 Apr 5, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 5, 2018

All of the tests needed to support gcc_arm.

@0xc0170

0xc0170 approved these changes Apr 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 5, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 5, 2018

Build : SUCCESS

Build number : 1666
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6540/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 23, 2018

Rerunning since last build is stale, but will be first in queue!

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 23, 2018

Build : SUCCESS

Build number : 1827
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6540/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 24, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 24, 2018

@cmonr cmonr merged commit b33ab74 into ARMmbed:master Apr 24, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8745 cycles (-550 cycles)
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment