New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Fix rate-limit issue with Github requests #6564

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
4 participants
@geky
Member

geky commented Apr 7, 2018

Using credentials avoids rate-limiting based on Travis's IP address

Description

Sometimes curl commands against the Github API fail. Turns out this is caused by rate-limiting when credentials aren't provided, which is then based on Travis's IP address. Always using credentials even for GETs to public endpoints fixes the problem.

Note, this isn't high priority since right now we're only using uncredentialed GETs in status messages.

Pull request type

[✓] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Fixed Travis rate-limit issue with Github requests
Using credentials avoids rate-limiting based on Travis's IP address

@geky geky requested a review from cmonr Apr 7, 2018

@geky geky added the needs: review label Apr 7, 2018

@0xc0170

0xc0170 approved these changes Apr 9, 2018

@0xc0170 0xc0170 requested a review from theotherjimmy Apr 9, 2018

@cmonr

cmonr approved these changes Apr 9, 2018

LGTM

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 10, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Apr 10, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1695
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6564/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 10, 2018

@cmonr cmonr merged commit 3bc2d2e into master Apr 10, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9037 cycles (-237 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@geky geky deleted the g-fix-rate-limit branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment