New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_F769NI: set clock_source to USE_PLL_HSE_EXTC #6567

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
4 participants
@bcostm
Contributor

bcostm commented Apr 9, 2018

Description

As noticed in Issue #6549 the clock_source configuration was incorrectly set for this board. The MCU is clocked with an external clock on OSCIN pin and not using an XTAL on OSCIN/OSCOUT pins.

Tested OK on all compilers.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 added the needs: CI label Apr 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 9, 2018

/morph build

@0xc0170

0xc0170 approved these changes Apr 9, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 9, 2018

Build : SUCCESS

Build number : 1684
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6567/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 10, 2018

Running test again. Starting to see patterns with 429ZI and lp_timer tests intermittently failing.

/morph test

@bcostm

This comment has been minimized.

Contributor

bcostm commented Apr 11, 2018

Running test again. Starting to see patterns with 429ZI and lp_timer tests intermittently failing.

We also noticed that since 5.8.1 (and also on master) many lptimer tests are fail now on many boards. So I don't think the failure you see here is related to this PR.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 11, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 11, 2018

We also noticed that since 5.8.1 (and also on master) many lptimer tests are fail now on many boards. So I don't think the failure you see here is related to this PR.

If you can think of any other issues that you think you've seen, feel free to open an issue and mention/tag/assign it to myself and/or @studavekar.

@cmonr cmonr merged commit 5234075 into ARMmbed:master Apr 12, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10173 cycles (+899 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 12, 2018

@bcostm bcostm deleted the bcostm:fix_xtal_disco_f769ni branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment