New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: small fixes #6569

Merged
merged 3 commits into from Apr 12, 2018

Conversation

Projects
None yet
7 participants
@kivaisan
Contributor

kivaisan commented Apr 9, 2018

Description

Small fixes to LoRa stack

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested review from AnttiKauppila and hasnainvirk Apr 9, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Apr 9, 2018

@kjbracey-arm, @AnttiKauppila, @hasnainvirk, please review this.

kivaisan added some commits Mar 27, 2018

Initialize mcps_indication status
_mcps_indication.status is not initialized properly and it can cause incorrect
status value to be returned.
Fix Coverity warning
Fixed Coverity warning "stored value is overwritten before it can be used".
@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Apr 10, 2018

@kivaisan This will need a rebase and testing again as Antti's stuff is in.

@kivaisan kivaisan force-pushed the kivaisan:LORAWAN_FEATURE_BRANCH branch from 0cd610b to dcaeed9 Apr 10, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Apr 10, 2018

Rebased to latest mbed-os. @0xc0170 could you please start required builds / tests.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 10, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 10, 2018

To understand this PR - there are 3 commits that look like fixes and the last one as adding new functionality that can be separate PR (feature) ?
/morph build

@kivaisan kivaisan force-pushed the kivaisan:LORAWAN_FEATURE_BRANCH branch from dcaeed9 to 01fd880 Apr 10, 2018

@kivaisan kivaisan changed the title from Lora: new receive() method and small fixes to Lora: small fixes Apr 10, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Apr 10, 2018

@0xc0170 this PR is now just those small fixes. I'll create a new PR (feature) about the new receive API.

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1700
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6569/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 10, 2018

Restarting build since commits were updated after last build was started.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1709
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6569/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2018

Sync failues for one device, I noticed this this morning, I restarted another job, will wait for results and this might need reconnect

@studavekar

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 12, 2018

@cmonr cmonr merged commit 68ebbb0 into ARMmbed:master Apr 12, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9194 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 12, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Apr 20, 2018

This edits code introduced by #6411 which is targeting 5.9, thus this cannot go to a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment