New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Introduce new receive API which returns port and flags #6586

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
6 participants
@kivaisan
Contributor

kivaisan commented Apr 10, 2018

Description

This is a fix for issue #6389.

Currently when application receives RX_DONE event from stack, it has to provide the correct port
value to receive method in order to read the received message. The problem is that current
API does not provide any way to know in to which port message was received.

This commit introduces a new receive() method, which instead of checking these values, will return
them to application.

This is mbed-os 5.9 content.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

Lora: Introduce new receive API which returns port and flags
This is a fix for issue #6389.

Currently when application receives RX_DONE event from stack, it has to provide the correct port
value to receive method in order to read the received message. The problem is that current
API does not provide any way to know in to which port message was received.

This commit introduces a new receive() method, which instead of checking these values, will return
them to application.
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Apr 10, 2018

@0xc0170

Any tests for this new method?

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Apr 10, 2018

@0xc0170 Tests are currently internal.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 10, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 10, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1706
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6586/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 10, 2018

Legitimately confused. Maybe the build machine ran out of space?
Rebuilding.

/morph export-build

/builds/ws/exporter-build-matrix/1340/NUCLEO_L476RG_make_armc5/sources/examples/mbed-os-example-blinky/Makefile:785: recipe for target 'mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_dfsdm.o' failed
Makefile:25: recipe for target 'all' failed
==========STDERR==========
"../mbed-os/features/filesystem/fat/ChaN/ff.cpp", line 1660: Warning:  #1293-D: assignment in condition
"../mbed-os/features/filesystem/fat/ChaN/ff.cpp", line 5585: Warning:  #1293-D: assignment in condition
"../mbed-os/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP.h", line 37: Warning:  #3135-D: attribute does not apply to any entity
"../mbed-os/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP_CellularNetwork.h", line 39: Warning:  #3135-D: attribute does not apply to any entity
"../mbed-os/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP_CellularPower.h", line 38: Warning:  #3135-D: attribute does not apply to any entity
"../mbed-os/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP_CellularNetwork.h", line 39: Warning:  #3135-D: attribute does not apply to any entity
"../mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_can_legacy.c", line 123: Warning:  #1215-D: #warning directive: 'Legacy HAL CAN driver is enabled! It can be used with known limitations, refer to the release notes. However it is recommended to use rather the new HAL CAN driver'
"../mbed-os/features/nvstore/source/nvstore.cpp", line 137: Warning:  #2748-D: null argument provided for parameter marked with attribute "nonnull"
"no source": Warning:  #541-D: allowing all exceptions is incompatible with previous function "operator new(std::size_t)" (declared at line 78 of "/usr/local/ARM_Compiler_5.06u3/bin/../include/new")
"no source": Warning:  #541-D: allowing all exceptions is incompatible with previous function "operator new[](std::size_t)" (declared at line 97 of "/usr/local/ARM_Compiler_5.06u3/bin/../include/new")
"no source": Warning:  #541-D: allowing all exceptions is incompatible with previous function "operator new(std::size_t, const std::nothrow_t &)" (declared at line 84 of "/usr/local/ARM_Compiler_5.06u3/bin/../include/new")
"no source": Warning:  #541-D: allowing all exceptions is incompatible with previous function "operator new[](std::size_t, const std::nothrow_t &)" (declared at line 109 of "/usr/local/ARM_Compiler_5.06u3/bin/../include/new")
"no source": Warning:  #541-D: allowing all exceptions is incompatible with previous function "operator delete(void *)" (declared at line 81 of "/usr/local/ARM_Compiler_5.06u3/bin/../include/new")
"no source": Warning:  #541-D: allowing all exceptions is incompatible with previous function "operator delete[](void *)" (declared at line 100 of "/usr/local/ARM_Compiler_5.06u3/bin/../include/new")
"../mbed-os/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP_CellularPower.h", line 38: Warning:  #3135-D: attribute does not apply to any entity
../mbed-os/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP.cpp: 3 warnings, 0 errors
../mbed-os/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP_CellularNetwork.cpp: 1 warning, 0 errors
../mbed-os/features/filesystem/fat/ChaN/ff.cpp: 2 warnings, 0 errors
../mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_can_legacy.c: 1 warning, 0 errors
../mbed-os/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP_CellularPower.cpp: 1 warning, 0 errors
Fatal error: A1023E: File "/tmp/fileFbbAgF" could not be opened: No such file or directory
1 Error, 0 Warnings
../mbed-os/features/nvstore/source/nvstore.cpp: 1 warning, 0 errorsmake[1]: *** [mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_dfsdm.o] Error 1
make[1]: *** Waiting for unfinished jobs....
@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 12, 2018

@cmonr cmonr merged commit 94103f9 into ARMmbed:master Apr 12, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9033 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment