New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRa: Internal include paths corrected #6587

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
7 participants
@AnttiKauppila
Contributor

AnttiKauppila commented Apr 10, 2018

Description

Internal include paths were using paths starting with lorawan which is not necessary.
In some cases .cpp files included it's .h file with full internal path.
These are now harmonised in this PR.

This is 5.9 content

Pull request type

[ ] Fix
[ X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Apr 10, 2018

@kivaisan @kjbracey-arm Can you please review this?
@0xc0170 Can you trigger a build for this when system is ready

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 10, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label Apr 10, 2018

@0xc0170 0xc0170 requested a review from kjbracey-arm Apr 10, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1704
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6587/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 12, 2018

@cmonr cmonr merged commit e1a63f9 into ARMmbed:master Apr 12, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8635 cycles (-8 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
@adbridge

This comment has been minimized.

Contributor

adbridge commented Apr 20, 2018

As the header states : "This is 5.9 content" this should probably not have been tagged with 5.8.3...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment