Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRa: Internal include paths corrected #6587

Merged
merged 1 commit into from Apr 12, 2018

Conversation

AnttiKauppila
Copy link

Description

Internal include paths were using paths starting with lorawan which is not necessary.
In some cases .cpp files included it's .h file with full internal path.
These are now harmonised in this PR.

This is 5.9 content

Pull request type

[ ] Fix
[ X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@AnttiKauppila
Copy link
Author

@kivaisan @kjbracey-arm Can you please review this?
@0xc0170 Can you trigger a build for this when system is ready

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1704
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6587/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Apr 12, 2018

@cmonr cmonr merged commit e1a63f9 into ARMmbed:master Apr 12, 2018
@adbridge
Copy link
Contributor

As the header states : "This is 5.9 content" this should probably not have been tagged with 5.8.3...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants