New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework us_ticker and rtc_api/lp_ticker | Fix compiler warning for spi_api #6605

Merged
merged 4 commits into from Apr 16, 2018

Conversation

Projects
None yet
4 participants
@khariya
Contributor

khariya commented Apr 11, 2018

Description

Fix issue: #5309

Simplify tickers to stop emulating 1us ticks by using native timer resolutions.
Implement ticker get info functions.
Separate rtc and lp ticker init status by implementing separate functions.
Add mbed_critical include file to disable compiler warning messages.

Tested all supported toolchains with MAX32625MBED.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Rework us_ticker and rtc_api/lp_ticker | Fix compiler warnings for sp…
…i_api

Simplify tickers to stop emulating 1us ticks by using native timer resolutions.
Implement ticker get info functions.
Separate rtc and lp ticker init status by implementing separate functions.
Add mbed_critical include file to disable compiler warning messages.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 12, 2018

Simplify tickers to stop emulating 1us ticks by using native timer resolutions.
Implement ticker get info functions.
Separate rtc and lp ticker init status by implementing separate functions.
Add mbed_critical include file to disable compiler warning messages.

I approved the code changes. Looking at the commit message, these might be separate commits. At least the last one is not related to the tickers update. Please separate logical changes

Please review and let us know if any corrections done, we will trigger CI then

khariya added some commits Apr 12, 2018

Rework us_ticker and rtc_api/lp_ticker
Simplify tickers to stop emulating 1us ticks by using native timer resolutions.
Implement ticker get info functions.
Separate rtc and lp ticker init status by implementing separate functions.
Fix compiler warning for spi_api
Add mbed_critical include file to disable compiler warning messages.
@khariya

This comment has been minimized.

Contributor

khariya commented Apr 12, 2018

I committed the changes as separate commits. Can you please trigger CI?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 13, 2018

Appreciate it 👍

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 13, 2018

Build : SUCCESS

Build number : 1739
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6605/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 13, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 13, 2018

/morph mbed2-build

@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (C) 2016 Maxim Integrated Products, Inc., All Rights Reserved.
* Copyright (C) 2016,2018 Maxim Integrated Products, Inc., All Rights Reserved.

This comment has been minimized.

@cmonr

cmonr Apr 14, 2018

Contributor

Interesting. Is this a valid license header? I've never seen one with the years split like this.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 16, 2018

/morph mbed2-build

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 16, 2018

@cmonr cmonr merged commit 63412bb into ARMmbed:master Apr 16, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8708 cycles (-245 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 16, 2018

@khariya khariya deleted the maximmbed:max32625-rework-ticker branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment