New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: add plmn for CellularConnectionFSM #6629

Merged
merged 4 commits into from Apr 19, 2018

Conversation

Projects
None yet
5 participants
@jarvte
Contributor

jarvte commented Apr 13, 2018

Description

Added possibility to specify plmn to CellularConnectionFSM which to use when registering to a cellular network.

Internal ref to defect: IOTCELL-745

@AriParkkila please review

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from AriParkkila Apr 13, 2018

nsapi_error_t err = is_automatic_registering(auto_reg);
if (err == NSAPI_ERROR_OK && !auto_reg) { // when we support plmn add this : || plmn
// automatic registering is not on, set registration and retry
if (_plmn && _retry_count == 0) {

This comment has been minimized.

@AriParkkila

AriParkkila Apr 13, 2018

Contributor

Any chance to know current PLMN? It's possible that we might be registered in correct PLMN already.

}
} else {
if (_plmn) {
set_network_registration();

This comment has been minimized.

@AriParkkila

AriParkkila Apr 13, 2018

Contributor

Manual registration shall be as failure tolerant as automatic registration.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 13, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 16, 2018

Please also rebase to resolve a conflict

@jarvte jarvte force-pushed the jarvte:add_select_plmn_to_cellularfsm branch from 752e7f9 to 1990f63 Apr 17, 2018

@jarvte

This comment has been minimized.

Contributor

jarvte commented Apr 17, 2018

@0xc0170 conflicts solved

@0xc0170 0xc0170 changed the title from plmn used when registering can be given for CellularConnectionFSM to Cellular: add plmn for CellularConnectionFSM Apr 17, 2018

if (!names) {
tr_warn("Could not allocate new operator_names_t");
_at.resp_stop();
return _at.unlock_return_error();

This comment has been minimized.

@AriParkkila

AriParkkila Apr 18, 2018

Contributor

Should clear op_names and return out-of-memory error?

This comment has been minimized.

@jarvte

jarvte Apr 18, 2018

Contributor

yeah, might a better way. I'll fix.

tr_warn("Could not allocate new operator");
_at.resp_stop();
opsCount = idx;
return _at.unlock_return_error();

This comment has been minimized.

@AriParkkila

AriParkkila Apr 18, 2018

Contributor

Should clear operators and return out-of-memory?

This comment has been minimized.

@jarvte

jarvte Apr 18, 2018

Contributor

yes

*
* @param plmn operator in numeric format. See more from 3GPP TS 27.007 chapter 7.3.
*/
void set_plmn(const char* plmn);

This comment has been minimized.

@AriParkkila

AriParkkila Apr 18, 2018

Contributor

It's not clear when this need to be called and that this does not start PLMN reselection.

This comment has been minimized.

@jarvte

jarvte Apr 18, 2018

Contributor

I'll update documentation

if (strcmp(_plmn, op_names->numeric)) {
names_list.delete_all();
return true;
} else {

This comment has been minimized.

@AriParkkila

AriParkkila Apr 18, 2018

Contributor

redundant else

This comment has been minimized.

@jarvte

jarvte Apr 18, 2018

Contributor

removed

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 18, 2018

I am confused, approved but left few comments that indicate changes. I keep this needs work and should be updated

@jarvte

This comment has been minimized.

Contributor

jarvte commented Apr 18, 2018

@0xc0170 fixed the latest review comments. Should be ready now.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 18, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 18, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 18, 2018

Build : SUCCESS

Build number : 1785
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6629/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@jarvte

This comment has been minimized.

Contributor

jarvte commented Apr 19, 2018

@0xc0170 please merge so we can continue work on top this

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 19, 2018

@0xc0170 0xc0170 merged commit 9cc4302 into ARMmbed:master Apr 19, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8986 cycles (-542 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@jarvte jarvte deleted the jarvte:add_select_plmn_to_cellularfsm branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment