New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellular: Error messages #6632

Merged
merged 3 commits into from Apr 16, 2018

Conversation

Projects
None yet
7 participants
@TeemuKultala
Contributor

TeemuKultala commented Apr 13, 2018

Description

Error messages modified to give more information about failure causes

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@TeemuKultala TeemuKultala changed the title from Error messages to cellular: Error messages Apr 13, 2018

@TeemuKultala

This comment has been minimized.

Contributor

TeemuKultala commented Apr 13, 2018

@AriParkkila please review

@AriParkkila

Looks good to me.

@jarvte please review

@jarvte

jarvte approved these changes Apr 13, 2018

@@ -97,6 +98,20 @@ void AT_CellularNetwork::read_reg_params_and_compare(RegistrationType type)
int lac = -1, cell_id = -1, act = -1;
read_reg_params(type, reg_status, lac, cell_id, act);
switch (reg_status) {

This comment has been minimized.

@jarvte

jarvte Apr 13, 2018

Contributor

you could add this inside #if MBED_CONF_MBED_TRACE_ENABLE so when trace not enabled no extra code is generated

}
CellularSIM::SimState AT_CellularSIM::trace_sim_errors(void)

This comment has been minimized.

@jarvte

jarvte Apr 13, 2018

Contributor

you could add this inside #if MBED_CONF_MBED_TRACE_ENABLE so when trace not enabled no extra code is generated

@0xc0170 0xc0170 requested a review from jarvte Apr 13, 2018

@jarvte

jarvte approved these changes Apr 16, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 16, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 16, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 16, 2018

Build : SUCCESS

Build number : 1750
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6632/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 16, 2018

Unexpected error, restarting

/morph test

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 16, 2018

@cmonr cmonr merged commit 7f9e69d into ARMmbed:master Apr 16, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8941 cycles (+91 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 16, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Apr 20, 2018

This is based on top of changes introduced in #6496 which is for 5.9

@TeemuKultala TeemuKultala deleted the TeemuKultala:error_messages branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment