New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow library configs to override target configs #6658

Merged
merged 3 commits into from Apr 19, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Apr 17, 2018

Description

The documentation currently claims that libraries are allowed to
override target configuration. This fixes a bug that would prevent a
library configuration from overriding a target configuration.
Application configuration is unaffected.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 18, 2018

Please review travis failures and jenkins CI

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 18, 2018

@screamerbg

This comment has been minimized.

Member

screamerbg commented Apr 18, 2018

These definitely need fixing.

@0xc0170 0xc0170 requested a review from sg- Apr 18, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 18, 2018

@screamerbg

These definitely need fixing.

Agreed. I'm working on it.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 18, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 18, 2018

Build : SUCCESS

Build number : 1791
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6658/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 19, 2018

/morph export-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 19, 2018

Agreed. I'm working on it.

@theotherjimmy Is this complete?

@mbed-ci

This comment has been minimized.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 19, 2018

@0xc0170 Yes.

@0xc0170

0xc0170 approved these changes Apr 19, 2018 edited

@screamerbg Approval, LGTM as well

@0xc0170 0xc0170 merged commit 42d77ec into ARMmbed:master Apr 19, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10107 cycles (+1554 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment