New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: fixed null pointer bug in cellular fsm #6677

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
5 participants
@jarvte
Contributor

jarvte commented Apr 19, 2018

Description

Cellular: fixed possible crash bug in cellular state machine.
After stop() call there might have been a call to null pointer.

@AriParkkila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from AriParkkila Apr 19, 2018

@0xc0170 0xc0170 changed the title from Cellular: fixed possible crash bug in cellular state machine. to Cellular: fix possible crash bug in cellular state machine. Apr 19, 2018

@0xc0170

How does it crash and how is it fixing? (add some detailed info to the commit message if possible)

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 19, 2018

@jarvte jarvte changed the title from Cellular: fix possible crash bug in cellular state machine. to Cellular: fix possible crash bug in cellular state machine. After stop() call there might have been a call to null pointer. Apr 19, 2018

@jarvte

This comment has been minimized.

Contributor

jarvte commented Apr 19, 2018

@0xc0170 updated commit and pr message

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 19, 2018

@0xc0170 updated commit and pr message

I see the title changed (the title should be 50 characters the most, same as first line in the commit message. The title here is used also in the release notes). The commit message (1st paragraph should contain the details about it). but commit has not changed, a push missing?

Cellular: fixed null pointer bug.
Null pointer could have been called after stop() in cellular state machine.

@jarvte jarvte force-pushed the jarvte:cellular_fsm_crash_bug branch from c345d08 to 6a2eefb Apr 19, 2018

@jarvte jarvte changed the title from Cellular: fix possible crash bug in cellular state machine. After stop() call there might have been a call to null pointer. to Cellular: fixed null pointer bug in cellular fsm Apr 19, 2018

@0xc0170 0xc0170 added needs: review and removed needs: work labels Apr 19, 2018

@0xc0170 0xc0170 removed the needs: review label Apr 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 20, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 20, 2018

Build : SUCCESS

Build number : 1816
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6677/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@jarvte

This comment has been minimized.

Contributor

jarvte commented Apr 25, 2018

@0xc0170 merge?

@0xc0170 0xc0170 merged commit d768b6f into ARMmbed:master Apr 25, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9614 cycles (-531 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@jarvte jarvte deleted the jarvte:cellular_fsm_crash_bug branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment