New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM3DS Maintenance Pull Request: Cleaning #6696

Merged
merged 4 commits into from Apr 27, 2018

Conversation

Projects
None yet
4 participants
@hug-dev
Contributor

hug-dev commented Apr 20, 2018

As it was discussed in this overarching pull request #6119 and now that all of the preceding pull requests have been merged:

  • CM3DS Maintenance Pull Request: Bug fixes (1/4) #6167
  • CM3DS Maintenance Pull Request: Memory changes (2/4) #6168
  • CM3DS Maintenance Pull Request: TRNG support (3/4) #6169
  • CM3DS Maintenance Pull Request: Driver updates (4/4) #6170

I am able to issue this last pull request.
It introduces four commits targeting CM3DS.

The pull request has been tested with the mbed OS Cloud Client example on all 3 compilers supported: ARM, GCC_ARM and IAR. Greentea tests were executed successfully for GCC_ARM (gcc_tests.txt).

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 20, 2018

Changes looks good to me, but the commit 627c037 - do you think that one should be split (introduces lot of changes that not all of them are related)

@hug-dev

This comment has been minimized.

Contributor

hug-dev commented Apr 20, 2018

Thanks.
I agree, I did not realise but it is a bit too much of a mix! I am going to split 627c037 and push again.

hug-dev added some commits Apr 20, 2018

CM3DS: merge the two system header files into one
This commit does not bring functional changes.
Here is the list of changes:
- merge CMSDK_CM3DS.h and SMM_MPS2.h into CM3DS.h
- remove unused code
- split copyright headers from first comment of each file

Change-Id: I79b7ee01689439b7d2fde9d13035a5edf17f69ff
Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
CM3DS: fix clock frequency value
This commit changes the clock frequency to the good value of 25 MHz.

Change-Id: I18e559718619e3b1942c42fda2413b690c7b5852
Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
CM3DS: fix compiler warnings
This commit changes the code to fix the compiler warnings on ARM,
GCC_ARM and IAR.

Change-Id: I92676d2cc85daacde9f43f1898377a2cea750c50
Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
CM3DS: switch us_ticker HAL to the tick domain
This commit changes the conversion function to do all the calculation
inside the HAL in ticks instead of microseconds.
The conversion will be done in Mbed OS side.
As SystemCoreClock is not a constant, it can not be used to initialise
the ticker_info_t structure.

Change-Id: I8fd4bf20dc5be8b965aca45f800a631275ccc724
Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

@hug-dev hug-dev force-pushed the hug-dev:cm3ds-cleaning branch from 4511fca to e4b4a2f Apr 20, 2018

@hug-dev

This comment has been minimized.

Contributor

hug-dev commented Apr 20, 2018

I have just split the commit into 3, 9f107d2 is still quite big but more splitting would not be beneficial in my opinion.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 26, 2018

Build : SUCCESS

Build number : 1860
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6696/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 27, 2018

Considering this as a refactor in leiu of a fix, and marking the release version as appropriate.

@cmonr cmonr merged commit d06ad9b into ARMmbed:master Apr 27, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9564 cycles (+643 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment