New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make poll() use RTOS tick count #6698

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
6 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Apr 20, 2018

Description

RTOS maintains a tick count - use it, avoiding issues with sleep and low power timers.

This follows on from similar changes in #6653 and #6693

Supersedes #6418 for RTOS builds.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Apr 20, 2018

@amq - should still work for you, I hope.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:poll-ticks branch from 18f8123 to 8533087 Apr 23, 2018

@kjbracey-arm kjbracey-arm requested a review from geky Apr 23, 2018

@geky

Looks good to me 👍

if (timeout > 0) {
start_time = Kernel::get_ms_count();
}
#define time_elapsed() int64_t(Kernel::get_ms_count() - start_time)

This comment has been minimized.

@geky

geky Apr 23, 2018

Member

Nit: Should this be in all-caps as a macro?

Make poll() use RTOS tick count
RTOS maintains a tick count - use it, avoiding issues with sleep and low
power timers.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:poll-ticks branch from 8533087 to 39fa676 Apr 23, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 23, 2018

@geky leave approve/request changes please

@geky

geky approved these changes Apr 23, 2018

Ah, I thought I did approve

@geky

geky approved these changes Apr 23, 2018

Oh, I did, it was dismissed by an update. I understand now.

@0xc0170 0xc0170 requested a review from bulislaw Apr 23, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 25, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 25, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 25, 2018

Build : SUCCESS

Build number : 1853
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6698/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 25, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 26, 2018

@cmonr cmonr merged commit 95156ce into ARMmbed:master Apr 27, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8954 cycles (+33 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment