New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix to prefer IPv6 single stack with fallback to IPv4 #6702

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
6 participants
@AriParkkila
Contributor

AriParkkila commented Apr 23, 2018

Description

Cellular accepted IPV4V6 dual stack but actual stack implementation supports only IPv4 or IPv6 single stack. At this same change also added stack init and socket flags to initialize modem stack for IPv4/IPv6 and to sync socket states.

Pull request type

[X ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Apr 23, 2018

Please review @mirelachirica @jarvte

@0xc0170 0xc0170 requested review from mirelachirica and jarvte Apr 23, 2018

@jarvte

jarvte approved these changes Apr 23, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 23, 2018

This is a fix that introduces new API : socket_stack_init ? Just to be sure about the proper release label

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Apr 23, 2018

socket_stack_init() is part of AT implementation (not API) and no application shall use directly any of classes at AT folder. Applications must rely on classes located in API folder.

socket_stack_init() has also default empty implementation which module specific drivers can override but that is not mandatory.

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Apr 24, 2018

CI error is unlikely due to this change:
[Test suite: NUCLEO_F401RE_arm-none-eabi-gcc_ble0] One or more testcases didn't pass.
Details: https://jenkins-internal.mbed.com/job/ARMmbed/job/mbed-os-cliapp/job/master/10955/artifact/logs/NUCLEO_F401RE_arm-none-eabi-gcc_ble0.html

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 24, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 24, 2018

Build : SUCCESS

Build number : 1833
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6702/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 4c973e3 into ARMmbed:master Apr 24, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8906 cycles (-15 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 24, 2018

@AriParkkila AriParkkila deleted the AriParkkila:single-stack branch Sep 10, 2018

@AriParkkila AriParkkila restored the AriParkkila:single-stack branch Sep 10, 2018

@AriParkkila AriParkkila deleted the AriParkkila:single-stack branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment