New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRF52 SPI pin initialization #6717

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
5 participants
@marcuschangarm
Contributor

marcuschangarm commented Apr 23, 2018

SPI pins are not initialized correctly according to the current SPI mode.

This commit changes how the SPI instance is configured and ensures
that:

  1. SPI pins are initialized on each object initialization.
  2. SPI pins are reinitialized on each mode or object change.
  3. SPI instance is only initialized when a change has occured.

Description

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Fix NRF52 SPI pin initialization
SPI pins are not initialized correctly according to the current
SPI mode.

This commit changes how the SPI instance is configured and ensures
that:

1. SPI pins are initialized on each object initialization.
2. SPI pins are reinitialized on each mode or object change.
3. SPI instance is only initialized when a change has occured.

@0xc0170 0xc0170 added the needs: CI label Apr 24, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 24, 2018

Build : SUCCESS

Build number : 1842
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6717/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

cmonr approved these changes Apr 24, 2018

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit a858454 into ARMmbed:master Apr 25, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9939 cycles (+856 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
@adbridge

This comment has been minimized.

Contributor

adbridge commented May 4, 2018

NRF5x does not exist on the 5.8 branch... Came in on this PR #6547, for 5.9

@marcuschangarm marcuschangarm deleted the marcuschangarm:fix-spi-pins branch May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment