New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Nordic SDK 14.2 I2C driver #6721

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
4 participants
@marcuschangarm
Contributor

marcuschangarm commented Apr 23, 2018

Interrupts were not enabled before transmitting data leading to
missed interrupts.

Description

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Fix bug in Nordic SDK 14.2 I2C driver
Interrupts were not enabled before transmitting data leading to
missed interrupts.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 24, 2018

As I can see some other bug fixes in their driver, do we keep a list of what we are changing , so can be sent upstream for review (or kept as a log for us what has changed in the driver).
We do not usually touch SDK.

Changes look good to me

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 25, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 25, 2018

Build : SUCCESS

Build number : 1855
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6721/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 9d6d8c7 into ARMmbed:master Apr 27, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9952 cycles (+869 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 27, 2018

@marcuschangarm marcuschangarm deleted the marcuschangarm:fix-sdk-i2c branch May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment