New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC54XXX: Set the pin function to Digital mode #6734

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
4 participants
@mmahadevan108
Contributor

mmahadevan108 commented Apr 24, 2018

Description

We cannot rely on the default value as a pin could be use for Analog purposes in which this bit is cleared. This was discovered when running AnalogIn ci-shield tests that uses the pin for Analog Input and then switches the pin to GPIO output.

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
LPC546XX: Set the pin function to Digital mode
We cannot rely on the default value as a pin could
be use for Analog purposes in which this bit is cleared

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Apr 24, 2018

@mmahadevan108 mmahadevan108 changed the title from LPC546XX: Set the pin function to Digital mode to LPC54XXX: Set the pin function to Digital mode Apr 24, 2018

@cmonr

cmonr approved these changes Apr 24, 2018

Nice catch!

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 24, 2018

Build : SUCCESS

Build number : 1841
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6734/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 25, 2018

@cmonr cmonr merged commit 4e1c04f into ARMmbed:master Apr 27, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9550 cycles (+467 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 27, 2018

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Fix_LPC54XXX_GPIO branch May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment