New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC546XX: Add check for GPIO IRQ #6735

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
4 participants
@mmahadevan108
Contributor

mmahadevan108 commented Apr 24, 2018

Description

GPIO IRQ is available on pins for Ports 0 & 1. Add a check to return error for other ports.

PR type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
LPC546XX: Add check for GPIO IRQ
GPIO IRQ is available on pins for Ports 0 & 1. Add
a check to return error for other ports.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Apr 24, 2018

@cmonr

cmonr approved these changes Apr 24, 2018

Looks reasonable to me.

@@ -25,6 +25,8 @@
#include "fsl_pint.h"
#include "mbed_error.h"
#define INTERRUPT_PORTS 2

This comment has been minimized.

@cmonr

cmonr Apr 24, 2018

Contributor

I suppose all LPC targets only have two ports that are interruptible?

This comment has been minimized.

@mmahadevan108

mmahadevan108 Apr 24, 2018

Contributor

Yes.

@cmonr cmonr requested review from 0xc0170 and maclobdell Apr 24, 2018

@cmonr cmonr added the needs: CI label Apr 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 24, 2018

Build : SUCCESS

Build number : 1845
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6735/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit beb8da9 into ARMmbed:master Apr 25, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8875 cycles (-730 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Add_GPIO_IRQ_Check branch May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment