New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Split add_mac_command() into separate methods #6741

Merged
merged 1 commit into from Apr 30, 2018

Conversation

Projects
None yet
6 participants
@kivaisan
Contributor

kivaisan commented Apr 25, 2018

Description

In order to have smaller and better testable methods, instead of having a big
switch-case -style add_mac_command(), each MAC command is now separated to an
own method.

This has been tested with our internal Lora tests.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Lora: Split add_mac_command() into separate methods
In order to have smaller and better testable methods, instead of having a big
switch-case -style add_mac_command(), each MAC command is now separated to an
own method.
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Apr 25, 2018

@0xc0170 0xc0170 requested a review from kjbracey-arm Apr 25, 2018

@0xc0170 0xc0170 requested a review from hasnainvirk Apr 25, 2018

@hasnainvirk

A minor comment. Looks good.

<< 8;
rxParamSetupReq.frequency |= (uint32_t) payload[mac_index++]
<< 16;
rxParamSetupReq.frequency |= (uint32_t) payload[mac_index++] << 8;

This comment has been minimized.

@hasnainvirk

hasnainvirk Apr 26, 2018

Contributor

style

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 26, 2018

Build : SUCCESS

Build number : 1862
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6741/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added needs: CI and removed needs: review labels Apr 27, 2018

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 27, 2018

@cmonr

cmonr approved these changes Apr 30, 2018

@cmonr cmonr merged commit 46379d8 into ARMmbed:master Apr 30, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9553 cycles (-631 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment